fix: handle missing microphone permission for voice recording#277
Open
yadavnikhil03 wants to merge 1 commit intomonogram-android:developfrom
Open
fix: handle missing microphone permission for voice recording#277yadavnikhil03 wants to merge 1 commit intomonogram-android:developfrom
yadavnikhil03 wants to merge 1 commit intomonogram-android:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting a voice recording without RECORD_AUDIO permission used to fail silently. The composer would just do nothing, which made the flow feel stuck.
This change routes that case through the chat input screen so the app can ask for microphone permission directly instead of leaving the user with a dead tap. The recorder now exposes a permission-denied callback, and the chat bar uses it when recording cannot start.