Skip to content

fix: restore Hardhat CI OpenZeppelin dependency - #10

Open
moonrager13 wants to merge 5 commits into
mainfrom
fix-ci-openzeppelin
Open

fix: restore Hardhat CI OpenZeppelin dependency#10
moonrager13 wants to merge 5 commits into
mainfrom
fix-ci-openzeppelin

Conversation

@moonrager13

Copy link
Copy Markdown
Owner

Fixes the failing Hardhat test workflow identified from Actions logs.

  • Adds the missing exact @openzeppelin/contracts 5.6.1 dependency required by contracts/AgentExecutorAccess.sol.
  • Updates the artifact workflow to use npm install, so the newly declared dependency is installed even though the existing lockfile predates it.
  • No deployment or blockchain execution changes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 386becb9f5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
"license": "CC0-1.0",
"dependencies": {
"@docusaurus/core": "^3.9.2",
"@openzeppelin/contracts": "5.6.1",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Regenerate the lockfile with the new dependency

Adding @openzeppelin/contracts here without updating package-lock.json leaves the committed lockfile out of sync: the lockfile root dependencies still omit this package and there is no node_modules/@openzeppelin/contracts entry. I checked the remaining workflows, and .github/workflows/ci.yml, validate.yml, build-check.yml, release.yaml, and others still run npm ci; the npm-ci(1) docs state that if package-lock dependencies do not match package.json, npm ci exits instead of updating the lock. Those CI jobs will fail before compiling/tests until the lockfile is regenerated or the workflows are changed consistently.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant