Repository navigation
quest: plan draft-22 media on the 0.17 release line - #5062
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Grok review of I checked the plan against Non-blocking
Verdict: ITERATE. Only #1 really matters, since it names a release PR that would duplicate a changelog heading and gives the wrong version for the cut. This is an automated review, not the maintainer's decision |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 8d15dba
No actionable findings in the full seven-file planning diff. The direction is sound: isolated Rust/JS backports with the existing regression and byte-vector tests, followed by release-line versioning. The current release ancestry excludes #4741, so the broadcast-epoch exemption is justified without a broader main-to-release merge.
Verification: cross-checked the linked quests, release policy/workflows, release-branch codec/subscriber code, and #5027/#5028/#4944. This was a static, GitHub-only review; I did not run tests or verify external crate publication or the reporter's rig. Quest CI passed; Check and Test were still running at the last check. Rechecked open/non-draft state, unchanged head/base, and the absence of prior reviews immediately before posting.
(Written by an OpenAI model)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Fixed in c85e57a: the release-22 README now has the cut waiting for the release-plz PR to regenerate as 0.17.3 after the backports land, instead of merging #4944. Summary: plans (Written by Claude Opus 5.5) |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: c85e57a
Rechecked the one-file change since 8d15dba; the base is unchanged.
Fixed: quest/m0/release-22/README.md:30-33 now waits for the regenerated release-plz PR after the backports and targets 0.17.3. This addresses point 1 of the existing review: I independently confirmed the published 0.17.2 GitHub release, the release-branch manifest, and #4944's stale target.
No new actionable findings. The isolated Rust/JS backports followed by a regenerated release cut remain the right direction.
Verification: static, GitHub-only review of this repository; no tests run, external crate publication or reporter interop verified. Rechecked open/non-draft state, head/base, and current reviews before posting.
|
Grok review of c85e57a (planning-only quest PR) I checked the claims against
No blocking issues. Non-blocking:
Verdict: MERGE (the notes above are wording and scope fixes and can land in a follow-up) This is an automated review, not the maintainer's decision |
Summary
Plans a 0.17.x before Seattle interop (2026-10-12) with draft-22 media working both ways, from an imquic draft-22 rig report:
main.New quests:
quest/m0/release-22/README.md(questline): bump@moq/netonrelease, merge the regenerated release-plz PR (0.17.3), offer the reporter the branch.noq.md[XS]:releaseon moq-noq 1.3.4.first-object.md[S]: backport fix(net): accept a clear FIRST_OBJECT that starts at object 0 #5027, Rust and JS.location-filter.md[S]: backport the moq-net: draft-22 LOCATION_FILTER should drop the Length and carry the Location Filter Type #4847 fix; requiresquest/m0/ietf-location-filter-22.md.quest/m0/noq-2.0.2.md[XS]:mainon moq-noq 2.0.2.m0's Plan now says backport patches from
releasearen't held by the broadcast-epoch gate.The moq-noq 1.3.4 and 2.0.2 release PRs had merged in moq-dev/noq but were never tagged. During planning,
v1.3.4andv2.0.2were pushed andmoq-release.ymlpublished both to crates.io.Decisions
Goal: ship one 0.17.x before Seattle with #4847, #5027, and noq 1.3.4, verified on the reporter's rig?
Who pushes the noq v1.3.4 / v2.0.2 tags?
Main moq-noq 2.0.2 bump?
Gate the cut on the reporter's rig?
Shape of the release work?
Backport scope?
Milestone for the main 2.0.2 bump?
Reply to the reporter?
Does the broadcast-epoch release gate hold release-line backports?
Public API / Wire
None (planning only).
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)