Skip to content

fix(net): abort malformed tracks received by group FETCH - #5619

Merged
kixelated merged 3 commits into
mainfrom
quest/m1/group-fetch-malformed
Oct 16, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m1/group-fetch-malformed

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

A standalone group FETCH receiving an object without its required Timestamp reports MalformedTrack but only aborts the fetched group. The timed track stays open, unlike live subgroup and joining FETCH handling.

Approach

Carry the request's shared track state into the receive handler and abort that track on MalformedTrack. Reuse the model's abort implementation without holding a publisher alive or allocating a new handle. Preserve the publisher's wire timescale. Exercise real request acceptance in the existing group FETCH tests.

Impact

  • No public API or wire-format change.
  • An invalid timed FETCH now ends its whole track with the existing MalformedTrack error. Ordinary group errors remain confined to the group.

Alternatives

An owned track producer adds lifetime and storage overhead that the request's existing shared state avoids. Deriving wire units from cached group metadata is invalid because cached timestamps are normalized.

Follow-ups

None. Completes /quest/m1/group-fetch-malformed.md. A release backport would make this receiver fix available to published clients.

Validation: regression fails on the base; all 13 focused group FETCH cases pass. Nix just check passed 6,607 default tests, 892 minimal-feature tests, 466 capture tests, 192 play tests, and all lint/docs/feature/tooling gates. just test interop --all passed all media, authorization, CLI FETCH and finite-tail lanes. Quest and diff checks pass.

(Written by GPT-6)

@kixelated
kixelated marked this pull request as ready for review October 15, 2026 23:30
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T23:33:14.230932Z 7b2c056 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 32 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8ff23246-fff5-4ae7-ba84-14e3cdab4b56
📥 Commits

Reviewing files that changed from the base of the PR and between 68c59cb and 7b2c056.

📒 Files selected for processing: 4
  • quest/m1/README.md
  • quest/m1/group-fetch-malformed.md
  • rs/moq-net/src/ietf/subscriber.rs
  • rs/moq-net/src/model/track.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

  • Merged main (clean, no conflicts); focused group FETCH tests still pass.
  • Marked ready for review. Codex reviewed with a thumbs-up and no findings.
  • io_uring failed once on bursts_cross_a_transport_peer::impaired ("the route was withdrawn while the peer link was up"), a relay drill unrelated to this change, then once on a Rust cache 403. The rerun passed. That drill was expected to be fixed by deps: bump moq-noq for the lost handshake ACK fix #5457, which this branch includes, so it is flagged as a follow-up rather than handled here.
  • No decisions changed; the approach is as described.

(Written by Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 16, 2026
@kixelated
kixelated added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit 9268907 Oct 16, 2026
11 of 13 checks passed
@kixelated
kixelated deleted the quest/m1/group-fetch-malformed branch October 16, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant