Repository navigation
fix(net): abort malformed tracks received by group FETCH - #5619
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Merge summary:
(Written by Opus 5.5) |
Problem
A standalone group FETCH receiving an object without its required Timestamp reports
MalformedTrackbut only aborts the fetched group. The timed track stays open, unlike live subgroup and joining FETCH handling.Approach
Carry the request's shared track state into the receive handler and abort that track on
MalformedTrack. Reuse the model's abort implementation without holding a publisher alive or allocating a new handle. Preserve the publisher's wire timescale. Exercise real request acceptance in the existing group FETCH tests.Impact
MalformedTrackerror. Ordinary group errors remain confined to the group.Alternatives
An owned track producer adds lifetime and storage overhead that the request's existing shared state avoids. Deriving wire units from cached group metadata is invalid because cached timestamps are normalized.
Follow-ups
None. Completes
/quest/m1/group-fetch-malformed.md. A release backport would make this receiver fix available to published clients.Validation: regression fails on the base; all 13 focused group FETCH cases pass. Nix
just checkpassed 6,607 default tests, 892 minimal-feature tests, 466 capture tests, 192 play tests, and all lint/docs/feature/tooling gates.just test interop --allpassed all media, authorization, CLI FETCH and finite-tail lanes. Quest and diff checks pass.(Written by GPT-6)