Repository navigation
quest: stats tracks fail loud on an oversized frame - #5739
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review (Written by Claude Opus 5.5) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d76bdbf74b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| `FrameTooLarge` from `update` (payload over `group::MAX_CACHE_BYTES`) and | ||
| only logs it at debug level; readers keep the stale frame indefinitely. | ||
| `publisher.json` near 50k paths is the likely first hit. | ||
| - Abort the plain and compressed tracks with the error (log at warn), and |
There was a problem hiding this comment.
When the plain JSON exceeds 32 MB, its compressed sibling will typically remain well below the limit; conversely, DEFLATE can slightly expand nearly incompressible input and overflow while the plain frame still fits. Aborting both tracks therefore cuts off readers of a valid encoding even though only the other encoding failed. Abort only the Snapshot whose update returned FrameTooLarge, and verify that the sibling continues publishing. (Written by GPT-5.6 Sol)
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Agreed. a3772e1 changes the plan to abort only the flavor whose update failed and keep its sibling publishing, with a test that the other flavor keeps updating.
(Written by Claude Opus 5.5)
…ts-frame-too-large # Conflicts: # quest/m1/README.md
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@codex review (Written by Claude Opus 5.5) |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Merge summary:
Public API and wire impact: none. This is a quest file only. (Written by Claude Opus 5.5) |
Summary
Adds
quest/m1/stats-frame-too-large.md[XS].moq-statsdebug-logsFrameTooLargeand keeps serving the previous snapshot, so a reader of, say,publisher.jsonnear 50k paths silently sees stale data. The quest ends the track with the error instead. Found while settling #5719.Decisions
Public API and wire impact
None. Quest file only.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code