docs(quest): finish WebTransport refusal delivery verification by kixelated · Pull Request #5743 · moq-dev/moq

kixelated · 2026-10-16T17:52:33Z

Problem

The refusal-delivery quest remained open after #5664 brought the acknowledged-close fix and its regressions into main. The release line still pins web-transport-moq 1.3.5, which lacks the fix, and nothing tracked its backport once the quest was gone.

Approach

Verify the existing source delivery/cancellation regressions and the full cross-language interop matrix, preserving Chromium's exact close code 2 and unauthorized reason. Remove the completed quest and its parent reference.

Track the release backport in m0, mirroring the qmux credit backport pair:

quest/m0/refusal-close-backport-upstream.md: noq publishes a 1.3.x web-transport-moq with fix(web-transport-moq): acknowledge close capsules before teardown noq#40 backported to release/1.3.
quest/m0/refusal-close-backport.md (XS): release bumps its pin to that 1.3.x and reruns interop. Requires the upstream quest.

Validation: MOQ_STRICT=1 just check; MOQ_STRICT=1 just rs test -p moq-tokio --lib close_ (14 passed); MOQ_STRICT=1 just test interop --all (all checks passed, including 45 media cells, exact browser refusal, FETCH and finite tails). Local Chromium needed pinned Nix runtime libraries supplied only through the process environment; the initial run could not launch the browser. quest check passes.

Decisions

✅ Track the release backport as two m0 quests in this PR (an upstream 1.3.x publication plus an XS release pin) rather than merging without tracking or keeping this quest open (maintainer, 2026-10-16, from Codex's review).

Impact

Public API: none.
Wire: none. Existing CLOSE capsule framing and refusal codes remain unchanged.

Alternatives

Keep the quest open, duplicating the source fix already merged in #5664.

(written by GPT-6, updated by Claude Opus 5.5)

Co-Authored-By: GPT-6 <noreply@openai.com>

kixelated · 2026-10-16T17:52:48Z

Verified the existing ACK-delivery and cancellation regressions, strict just check, and the full just test interop --all matrix with exact Chromium refusal assertions unchanged. The initial run could not launch Chromium until its pinned Nix runtime libraries were supplied to the process. This remains draft for review. Recommend a separate exposure check and compatible 1.3.x source backport/release before changing the release adapter pin.

(written by GPT-6)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chatgpt-codex-connector · 2026-10-16T23:03:12Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-16T23:31:38.411471Z	`ad116e4`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-10-16T23:03:13Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 14 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 19b31a5a-dc36-45ee-820d-dc6791f79760

📥 Commits

Reviewing files that changed from the base of the PR and between 2aa7a95 and ad116e4.

📒 Files selected for processing: 5

quest/m0/README.md
quest/m0/refusal-close-backport-upstream.md
quest/m0/refusal-close-backport.md
quest/m1/test-flakes-2/README.md
quest/m1/test-flakes-2/interop-close-code.md

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

kixelated · 2026-10-16T23:03:13Z

@codex review

(Written by Claude Opus 5.5)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dcf5977cc9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-16T23:05:09Z

- Recommend a `release` backport after main lands. That branch pins the
-  1.3.5 adapter, so verify its exposure and use a compatible 1.3.x source
-  backport/release if needed; never move the published line to 2.x as a fix.
-  Split any required source-release condition before starting its pin PR.


Preserve tracking for the release-line backport

When the current release line refuses a browser WebTransport session, it still uses the affected 1.3.5 adapter and may surface "Connection lost" instead of unauthorized; this commit validates only the in-tree implementation on main. Deleting these lines without creating the suggested follow-up removes the only durable tracking for verifying and backporting a compatible 1.3.x fix, so retain this work or split it into an m0/deferred quest before closing the main adoption.

AGENTS.md reference: AGENTS.md:L48-L48

Useful? React with 👍 / 👎.

Agreed: release pins web-transport-moq 1.3.5 and no newer 1.3.x carries the fix. Fixed in ad116e4 by tracking the backport in m0, mirroring the qmux credit pair: quest/m0/refusal-close-backport-upstream.md (noq publishes a 1.3.x with noq#40 on release/1.3) and quest/m0/refusal-close-backport.md (XS release pin, requires the upstream quest).

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

kixelated · 2026-10-16T23:29:53Z

@codex review

(Written by Claude Opus 5.5)

chatgpt-codex-connector · 2026-10-16T23:31:37Z

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: ad116e4977

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

kixelated · 2026-10-16T23:41:11Z

Merging. Summary:

Verified the quest is done on main: feat(quic)!: run moq-tokio and moq-uring on moq-quic #5664 carries the acknowledged-close fix with close_waits_for_capsule_ack and close_ack_wait_ends_with_connection, and interop asserts the exact browser refusal.
Merged main to resolve the test-flakes-2 README conflict.
✅ Per the maintainer, the release backport Codex flagged is tracked in m0: refusal-close-backport-upstream.md (noq publishes a 1.3.x with noq#40) and refusal-close-backport.md (XS release pin).
Codex review of ad116e4 is clean; CI passed.

Public API: none. Wire: none.

(Written by Claude Opus 5.5)

kixelated and others added 2 commits October 16, 2026 10:30

chore: claim WebTransport refusal verification quest

5e91285

docs(quest): finish WebTransport refusal delivery verification

0558ddf

Co-Authored-By: GPT-6 <noreply@openai.com>

Merge origin/main into quest/m1/test-flakes-2/interop-close-code

dcf5977

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

kixelated marked this pull request as ready for review October 16, 2026 23:03

chatgpt-codex-connector Bot reviewed Oct 16, 2026

View reviewed changes

docs(quest): track the release backport of the acknowledged-close fix

ad116e4

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

kixelated added this pull request to the merge queue Oct 16, 2026

Merged via the queue into main with commit 1ab0716 Oct 17, 2026
7 checks passed

kixelated deleted the quest/m1/test-flakes-2/interop-close-code branch October 17, 2026 00:19

Navigation Menu

Repository navigation

docs(quest): finish WebTransport refusal delivery verification - #5743

docs(quest): finish WebTransport refusal delivery verification#5743
kixelated merged 4 commits into
mainfrom
quest/m1/test-flakes-2/interop-close-code

kixelated commented Oct 16, 2026 •

edited

Loading

Uh oh!

kixelated commented Oct 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 16, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 16, 2026 •

edited

Loading

Review limit reached

Uh oh!

kixelated commented Oct 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Oct 16, 2026

Uh oh!

kixelated Oct 16, 2026

Uh oh!

kixelated commented Oct 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 16, 2026

Uh oh!

kixelated commented Oct 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

kixelated commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Approach

Decisions

Impact

Alternatives

Uh oh!

kixelated commented Oct 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

kixelated commented Oct 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 16, 2026

Choose a reason for hiding this comment

Uh oh!

kixelated Oct 16, 2026

Choose a reason for hiding this comment

Uh oh!

kixelated commented Oct 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 16, 2026

Uh oh!

kixelated commented Oct 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kixelated commented Oct 16, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 16, 2026 •

edited

Loading

coderabbitai Bot commented Oct 16, 2026 •

edited

Loading