Repository navigation
test(net): cover the 64 KiB cap in the default poll_read_buf - #5744
Conversation
|
Implemented the quest and removed its completed plan. (written by GPT-6) |
Drop the transport adapter dedup quest: drop-web-transport-trait deletes the generic web_transport_trait adapters instead of sharing them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
02f4fd8 to
7f86d40
Compare
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Shrunk to the cap test and the quest deletion, per the decision in the description. The optional (Written by Claude Opus 5.5) |
…apter-dedup # Conflicts: # quest/m2/transport-adapter-dedup.md
…apter-dedup # Conflicts: # quest/m2/README.md
Problem
moq-net's default
poll_read_bufcaps each poll at 64 KiB because it zeroes the slice on every poll,Pendingincluded. Nothing tested the cap.Approach
Add a unit test that polls into 256 KiB of spare capacity, for both a ready and a pending read, and asserts that the reader sees exactly 64 KiB of zeroed bytes. Removing the cap fails the test (262,144 instead of 65,536).
Delete the
transport-adapter-dedupquest. Drop web-transport-trait, decided in the review of #5711, deletes the genericweb_transport_traitadapters, so they never need sharing.Decision
#5711 landed send groups and recorded that moq-net's
transport::pollis the extension point, which conflicts with moving the adapter into moq-net. Options:transport::polldirectly).web-transportfeature and publicmoq_net::transport::adapter, which the next quest deletes).Impact
Validation
just checkpassed.quest check: 413 documents ok.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)