Skip to content

test(net): cover the 64 KiB cap in the default poll_read_buf - #5744

Merged
kixelated merged 3 commits into
mainfrom
quest/m2/transport-adapter-dedup
Oct 17, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m2/transport-adapter-dedup

Conversation

@kixelated

@kixelated kixelated commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Problem
moq-net's default poll_read_buf caps each poll at 64 KiB because it zeroes the slice on every poll, Pending included. Nothing tested the cap.

Approach
Add a unit test that polls into 256 KiB of spare capacity, for both a ready and a pending read, and asserts that the reader sees exactly 64 KiB of zeroed bytes. Removing the cap fails the test (262,144 instead of 65,536).

Delete the transport-adapter-dedup quest. Drop web-transport-trait, decided in the review of #5711, deletes the generic web_transport_trait adapters, so they never need sharing.

Decision
#5711 landed send groups and recorded that moq-net's transport::poll is the extension point, which conflicts with moving the adapter into moq-net. Options:

  • ✅ Shrink this PR to the cap test and drop the quest as superseded.
  • Turn this PR into the first step of drop-web-transport-trait (browser backend implements transport::poll directly).
  • Finish the dedup as an interim step (optional web-transport feature and public moq_net::transport::adapter, which the next quest deletes).

Impact

  • Public API: none. Wire: none.

Validation

  • just check passed. quest check: 413 documents ok.
  • The new test fails with the cap removed and passes with it.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Implemented the quest and removed its completed plan. just check, just rs wasm, just test interop --all, and quest check pass. The cap test fails when the 64 KiB bound is removed. Public API: the optional shared adapter module and feature; FFI/binding API and wire behavior are unchanged. The browser environment needed the Nix Chrome wrapper, with no repository change. The passing FETCH teardown warnings are noted under the existing dropped sources follow-up. This PR stays draft for maintainer review, as requested for this batch.

(written by GPT-6)

Drop the transport adapter dedup quest: drop-web-transport-trait deletes
the generic web_transport_trait adapters instead of sharing them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated force-pushed the quest/m2/transport-adapter-dedup branch from 02f4fd8 to 7f86d40 Compare October 17, 2026 14:08
@kixelated kixelated changed the title refactor(net): share the WebTransport poll adapter test(net): cover the 64 KiB cap in the default poll_read_buf Oct 17, 2026
@kixelated
kixelated marked this pull request as ready for review October 17, 2026 14:08
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 40 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bb541f12-786f-449b-a9db-c11c1402d182
📥 Commits

Reviewing files that changed from the base of the PR and between 291e392 and b1e72f2.

📒 Files selected for processing: 3
  • quest/m2/README.md
  • quest/m2/transport-adapter-dedup.md
  • rs/moq-net/src/transport.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T14:09:46.381102Z 7f86d40 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Shrunk to the cap test and the quest deletion, per the decision in the description. The optional TS validation failure ("TS full multiplex at its own rate", mp2 holes) also hits unrelated PRs today and is the flake #5854 fixes. This PR only adds a moq-net unit test. The required Check and Test jobs pass, and Codex finished with no findings on 7f86d40.

(Written by Claude Opus 5.5)

…apter-dedup

# Conflicts:
#	quest/m2/transport-adapter-dedup.md
@kixelated
kixelated enabled auto-merge October 17, 2026 14:56
…apter-dedup

# Conflicts:
#	quest/m2/README.md
@kixelated
kixelated added this pull request to the merge queue Oct 17, 2026
Merged via the queue into main with commit ae9baed Oct 17, 2026
10 of 11 checks passed
@kixelated
kixelated deleted the quest/m2/transport-adapter-dedup branch October 17, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant