Repository navigation
fix(audio-quality): flush the build before the first row - #5807
Conversation
Co-Authored-By: GPT-6 <noreply@openai.com>
Temporary branch-only diagnostic workflow; restore Nightly before the final quest PR. Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: GPT-6 <noreply@openai.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Temporary branch-only experiment workflow; removed before the PR is ready. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…olated ring Deletes opus-isolated-target and leaves the budget re-measure waiting on post-fix nightlies; drops the temporary experiment workflow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Outcome: root-caused and fixed. The near-zero stall follows the first row after a cold build, not the isolated ring. Periodic writeback of about 800 MB of dirty build output froze the page's main thread every ~10 s for the first ~30 s. The ARM experiment reproduced it on the plain ring when that row went first. With Left as a draft for two small decisions, each with a recommendation in the body: where the flush lives, and whether the budget re-measure stays a separate waiting quest ( (Written by Opus 5.5) |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Merging via
Follow-up worth considering: check whether other timed harnesses ( (Written by Opus 5.5) |
Keep main's Audio rename quest in the epic's Required list, drop the finished Opus isolated-ring line, and point browser-rename-check's related link at the PR instead of the deleted quest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
The nightly's Opus
near-zeroisolatedrow reaches a 100 to 800 ms target with roughly one-second underrun episodes, while theplainrow holds 60 ms. #5617 traced it to 100 to 320 ms main-thread long tasks that delay arrivals, and to sampling gaps in the CPU profile, but did not find the cause.Root cause
It was never the isolated ring. That row just happens to be the matrix's first row, and it starts straight after
run.sh's coldcargo build.plain,isolatedharness ran second, after a no-op build./proc/meminfoshowed 800 MB dirty when the page loaded, flushed in 100 to 280 MB writeback bursts at exactly those moments (vmstatboup to 278 MB/s,waup to 17%). Once the backlog drained, about 30 s in, the long tasks stopped. In the same run, isolated-first with the build flushed beforehand held 60 ms with no long tasks.Fix
run.shrunssyncafter its builds and before the first row. The verification run used the nightly's original order (isolated first) straight after a 167 s cold build. The flush took 2.8 s. Both rows held a 60 ms target with zero underruns and no long task over 100 ms.Impact
opus-isolated-target.mdand adds Opus near-zero budgets, which waits on seven post-fix nightlies before re-measuring the ceilings, following the AAC bursty pattern.watch.mdno longer requires it.Validation
just checkpasses (includesquest check), andshellcheckonrun.shis clean.Decisions
Both settled by the maintainer:
syncafter builds stays intest/audio-quality/run.shonly. A sharedharness_*helper is a follow-up only if another timing harness turns out to build and then grade straight away.opus-near-zero-budgets.md, not folded intoaac-bursty-budgets.md, so it does not ride a different fix's nightly window.Branch history
The branch carries #5617's stale pre-squash commits beneath a
merge -s ours. The PR diff is clean (the five files above), and a squash merge drops them.Follow-ups
native-play, the drills) grade right after a cold build.(Written by Opus 5.5)
🤖 Generated with Claude Code