Skip to content

quest: pin benchmark cores and fold moq-quic into bench CI - #5814

Merged
kixelated merged 1 commit into
mainfrom
claude/moq-quic-bench-followups
Oct 17, 2026
Merged

kixelated merged 1 commit into
mainfrom
claude/moq-quic-bench-followups

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

Follow-ups from the moq-quic benchmarks (#5812):

  • quest/m1/quic/coverage/bench-pin.md [XS]: bench/run.sh pins both sides of a comparison to one core type on hybrid CPUs. On an 8P/16E host, one unpinned case measured 420 or 690 µs depending on the core.
  • quest/m2/bench-ci.md: moq-quic's Criterion targets join the planned paired base/head CI job. The quest's noise floor comes from A/A runs on the runner itself. This covers the "quiet benchmark runner" follow-up, so it does not get a duplicate quest.

The rewrites #5711, #5735 and #5674 were asked, in comments, to run just bench <#5812 merge> on a pinned, idle machine.

No code, public API, or wire impact.

Decisions

#5812 follow-ups to plan (multi-select)

  • ✅ Pin bench/run.sh cores
  • ✅ Quiet benchmark runner (folded into the existing quest/m2/bench-ci.md instead of a new quest; decided unattended, since that quest already plans same-runner paired comparisons)
  • ✅ Ask rewrites to compare (posted as comments, not a quest)

Pin quest placement (decided unattended)

  • ✅ moq-quic coverage epic, m1: it serves the open rewrites' comparisons
  • m2

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Follow-ups from the moq-quic benchmarks (#5812).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T00:42:06.755047Z 01e2289 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6ef8fb23-be08-4138-9921-6e3302acad15
📥 Commits

Reviewing files that changed from the base of the PR and between b7d7e99 and 01e2289.

📒 Files selected for processing: 3
  • quest/m1/quic/coverage/README.md
  • quest/m1/quic/coverage/bench-pin.md
  • quest/m2/bench-ci.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated
kixelated added this pull request to the merge queue Oct 17, 2026
Merged via the queue into main with commit c32bffc Oct 17, 2026
6 checks passed
@kixelated
kixelated deleted the claude/moq-quic-bench-followups branch October 17, 2026 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant