Repository navigation
quest: pin benchmark cores and fold moq-quic into bench CI - #5814
Conversation
Follow-ups from the moq-quic benchmarks (#5812). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Follow-ups from the moq-quic benchmarks (#5812):
quest/m1/quic/coverage/bench-pin.md[XS]:bench/run.shpins both sides of a comparison to one core type on hybrid CPUs. On an 8P/16E host, one unpinned case measured 420 or 690 µs depending on the core.quest/m2/bench-ci.md: moq-quic's Criterion targets join the planned paired base/head CI job. The quest's noise floor comes from A/A runs on the runner itself. This covers the "quiet benchmark runner" follow-up, so it does not get a duplicate quest.The rewrites #5711, #5735 and #5674 were asked, in comments, to run
just bench <#5812 merge>on a pinned, idle machine.No code, public API, or wire impact.
Decisions
#5812 follow-ups to plan (multi-select)
quest/m2/bench-ci.mdinstead of a new quest; decided unattended, since that quest already plans same-runner paired comparisons)Pin quest placement (decided unattended)
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code