Repository navigation
fix(ci): limit Discord alerts to cron and publishing failures - #5828
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Problem
Merge-queue failures were sent to Discord because Alert excluded PR events but accepted
merge_group. Ordinary branch checks also generated notifications.Approach
Watch cron and release/deployment workflows, excluding Check, Platform, OBS, Quest, and cache warming. Cron suites alert only on scheduled failures or timeouts; publishing failures still alert for pushes, dispatches, and chained releases. Update coverage validation and run regression tests in
just gh check.Validation:
just check origin/main, Biome on the new test, and the existing queue policy test pass. The new regression tests failed against the original configuration.Impact
Alternatives
Muting Discord would also hide nightly and release failures.
Follow-ups
The repeated queue failures from a stale quest dependency already have a fix on #5785. This PR changes notification policy only.
(written by GPT-6)