Skip to content

quest: delete the refusal-close release backport quests - #5831

Merged
kixelated merged 1 commit into
mainfrom
quest/m0/refusal-close-backport-upstream
Oct 17, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest/m0/refusal-close-backport-upstream

Conversation

@kixelated

@kixelated kixelated commented Oct 17, 2026 •

Copy link
Copy Markdown
Collaborator

Deletes quest/m0/refusal-close-backport-upstream.md and quest/m0/refusal-close-backport.md, and their entries in quest/m0/README.md. No other references exist.

Why: the release line will not be patched. The next release cut from main carries the acknowledged-close fix through moq-tokio's quic::web (#5664), so release does not need a web-transport-moq 1.3.6 pin. The noq backport (moq-dev/noq#42) and its 1.3.6 release PR (moq-dev/noq#43) are closed unmerged.

Quest deletions only. Public API: none. Wire: none.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

@kixelated

Copy link
Copy Markdown
Collaborator Author

Outcome: noq#42 (backport) and noq#43 (1.3.6 release) are open and pass their tests locally. Both regressions fail without the fix. noq CI never ran (no Actions runs in that repo since 2026-10-14). Blocked on a maintainer merging, tagging v1.3.6, and the crates.io publish.

(Written by Claude Opus 5.5)

The next release cut from main carries the acknowledged-close fix through
moq-tokio, so the release line will not be patched with noq 1.3.6.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated force-pushed the quest/m0/refusal-close-backport-upstream branch from 1beaf10 to 0683483 Compare October 17, 2026 03:24
@kixelated kixelated changed the title quest: retire the noq 1.3.x close-fix condition quest: delete the refusal-close release backport quests Oct 17, 2026
@kixelated
kixelated marked this pull request as ready for review October 17, 2026 03:24
@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c053bf88-7c35-4641-86a2-e8f6b9f45967
📥 Commits

Reviewing files that changed from the base of the PR and between 3789ee2 and 0683483.

📒 Files selected for processing: 3
  • quest/m0/README.md
  • quest/m0/refusal-close-backport-upstream.md
  • quest/m0/refusal-close-backport.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T03:26:02.876316Z 0683483 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Summary: deletes both refusal-close release backport quests and their quest/m0/README.md entries. Decision (maintainer): don't patch release; the next cut from main carries the acknowledged-close fix through moq-tokio. This supersedes the earlier outcome comment: moq-dev/noq#42 and #43 are closed unmerged. Codex review found nothing, and CI passes.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 17, 2026
Merged via the queue into main with commit e597a1e Oct 17, 2026
10 checks passed
@kixelated
kixelated deleted the quest/m0/refusal-close-backport-upstream branch October 17, 2026 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant