Skip to content

quest: plan five follow-ups from the 2026-10-19 batch - #6021

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/followups-2026-10-19
Oct 20, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/followups-2026-10-19

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

Adds five quests from a /quest-plan interview over the follow-ups of the latest merge batch:

  • quest/m0/ci/wasm-bindgen-pin.md [XS], first in the m0 CI epic: the dev shell's wasm-bindgen-cli follows the locked crate version, so a nixpkgs bump like #5896 cannot move the CLI away from the crate again (#5911 re-pinned).
  • Three children of quest/m1/test-flakes-2/README.md, which gains a Required list (and drops its size, now that it is an epic):
    • tokio-redial.md [S]: the moq-tokio redial tests stop assuming a dropped port stays free and stop racing 10 s deadlines (CI hit, 5 of 240 locally under load).
    • ffi-cancel-connect.md [XS]: confirm and close the suspected spawn_parked race in client_cancel_aborts_a_pending_connect (2 of 960 locally).
    • flapping-peer-reorder.md [XS]: replay seed 783778834340462316 on main; delete the quest if it passes.
  • quest/m2/mkv-dimension-overflow.md [XS], in m2 beside the fMP4 importer work: the Matroska importer errors instead of truncating with as u32, from the #5893 follow-ups.

quest check passes.

Decisions

  1. Which follow-ups become quests?
    • ✅ wasm-bindgen pin
    • ✅ moq-tokio redial
    • ✅ moq-ffi cancel
    • ✅ MKV overflow
  2. How does the wasm-bindgen CLI stay matched to the crate?
    • ✅ flake.nix reads the version from Cargo.lock and selects nixpkgs' wasm-bindgen-cli_0_2_<n>, failing at eval when nixpkgs lacks it
    • A CI step comparing the two versions (detects drift instead of removing it)
    • Make Dependabot's auto-merge wait for the WASM job
  3. The JS snapshot cap fix?
    • ✅ Extend the serve.md Rebinding bullet; that edit goes in #5924, not here
  4. Small fixes?
    • ✅ One direct-fix PR for the moq-quic clippy cfg, plus quest the flapping-peer seed
  5. The mp4-atom#246 reply?
    • ✅ The maintainer replies
  6. MKV follow-up scope?
    • ✅ Truncation only
    • Also match the SPS aspect ratio 1:1 (dropped: FFmpeg prefers the container SAR, and the maintainer accepted the FFmpeg rule)
    • Also add a catalog crop field (dropped: nothing needs one)

Dropped

  • Dependabot versioning-strategy: unsupported for the bun ecosystem.
  • quinn triage: zshenker's drafts #6010 through #6016 are doing it.
  • relay-burst seed 350628089381690431: fixed by #5943, replayed 20 of 20 passing.

Public API and wire impact

None. Quest files only.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Add the wasm-bindgen pin (m0 CI), three load flakes under test-flakes-2
(moq-tokio redial, moq-ffi cancel during connect, flapping-peer reorder
seed), and MKV import refusing out-of-range values (m2).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 597c9a58-d5e8-4f17-bbed-b270331f24ce
📥 Commits

Reviewing files that changed from the base of the PR and between 48c8a66 and b158e31.

📒 Files selected for processing: 8
  • quest/m0/ci/README.md
  • quest/m0/ci/wasm-bindgen-pin.md
  • quest/m1/test-flakes-2/README.md
  • quest/m1/test-flakes-2/ffi-cancel-connect.md
  • quest/m1/test-flakes-2/flapping-peer-reorder.md
  • quest/m1/test-flakes-2/tokio-redial.md
  • quest/m2/README.md
  • quest/m2/mkv-dimension-overflow.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T00:07:30.705173Z b158e31 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated
kixelated added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit 37457ec Oct 20, 2026
6 checks passed
@kixelated
kixelated deleted the quest-plan/followups-2026-10-19 branch October 20, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant