Repository navigation
feat(ietf): answer SUBSCRIBE_TRACKS through the TRACKS hook #6167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
d2f1e9d
quest(m1): claim archive/subscribe-tracks
kixelated 934b48d
feat(ietf): answer SUBSCRIBE_TRACKS through the TRACKS hook
kixelated 15d71d9
Merge remote-tracking branch 'origin/main' into quest/m1/archive/subs…
kixelated d2ee89f
fix(ietf): admit listing update IDs, honor NEW_GROUP_REQUEST, follow …
kixelated 52a080e
fix(ietf): keep absent PUBLISH_OK parameters and its NEW_GROUP_REQUEST
kixelated 1b46e29
fix(ietf): end an unlisted forwarding PUBLISH, keep the listing's NEW…
kixelated b3840d4
fix(ietf): end an unlisted PUBLISH in error, open its stream before i…
kixelated 12cd008
fix(ietf): cut a listed track's PUBLISH write once it is cancelled
kixelated 9d15474
docs(ietf): state that an unlisted PUBLISH always ends in error
kixelated e924495
Merge remote-tracking branch 'origin/main' into subscribe-tracks-d5
kixelated e19bd5d
fix(ietf): state a listing's parameters on draft-20 PUBLISH, gate NEW…
kixelated b2a93d4
fix(ietf): deliver a refused listing update's REQUEST_ERROR, accept i…
kixelated 5827160
Merge remote-tracking branch 'origin/main' into subscribe-tracks-d5
kixelated e2d2039
fix(ietf): carry no subscription parameters on a draft-18 SUBSCRIBE_T…
kixelated d09e9b8
fix(ietf): keep a listing's fill and a forwarding update's parameters…
kixelated 3d5fb6b
Merge remote-tracking branch 'origin/main' into subscribe-tracks-d5
kixelated 4ae2769
fix(ietf): refuse a listing update past our GOAWAY as GOING_AWAY
kixelated 0a34f80
Merge remote-tracking branch 'origin/main' into subscribe-tracks-d5
kixelated 417f434
fix(ietf): on draft-18, skip a relisted track whose PUBLISH is still …
kixelated ba27133
Merge remote-tracking branch 'origin/main' into subscribe-tracks-d5
kixelated aa35edd
fix(ietf): open no fill from a paused listing, drop MAX_AGE from SUBS…
kixelated a0369d1
Merge remote-tracking branch 'origin/main' into subscribe-tracks-d5
kixelated 3e136ff
fix(ietf): end a PUBLISH whose PUBLISH_OK asks a static track for a g…
kixelated 585ff47
Merge remote-tracking branch 'origin/main' into subscribe-tracks-d5
kixelated d87fc56
fix(ietf): refuse a listing update's TRACK_PROPERTY_FILTER per request
kixelated 2bfdd5f
fix(ietf): wait for the setup answer before listing tracks, refuse a …
kixelated 4fbf711
fix(ietf): unlist while a listing closes, answer a resume that fails
kixelated 5d44246
Merge remote-tracking branch 'origin/main' into pr-6167-merge
kixelated 693c506
style: rustfmt after merging main
kixelated 578da99
fix(ietf): free a listing's prefix when it is cancelled awaiting the …
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # [M] SUBSCRIBE_TRACKS in js/net | ||
|
|
||
| ## Goal | ||
|
|
||
| `@moq/net` answers a moq-transport SUBSCRIBE_TRACKS (draft-18 on) as Rust | ||
| does, instead of refusing it with NOT_SUPPORTED: a paused PUBLISH per listed | ||
| track for FORWARD=0, resumed and paused with REQUEST_UPDATE; PUBLISH_SKIPPED | ||
| past the subscription cap and for every track of a FORWARD=1 listing from | ||
| draft-19; NOT_SUPPORTED for FORWARD=1 on draft-18; PREFIX_OVERLAP for an | ||
| overlapping prefix; and draft-18's DUPLICATE_SUBSCRIPTION for a SUBSCRIBE to | ||
| a PUBLISHed track. | ||
|
|
||
| ## Plan | ||
|
|
||
| Mirror `rs/moq-net/src/ietf/publisher/tracks.rs`, reading tracks through the | ||
| TRACKS listing that [TRACKS in js/net](/quest/m1/archive/tracks-js.md) adds. | ||
| Mirror its tests, and drop the JavaScript caveat from | ||
| `doc/concept/standard.md`. | ||
|
|
||
| ## Required | ||
|
|
||
| - [TRACKS in js/net](/quest/m1/archive/tracks-js.md) - `@moq/net` lists a broadcast's tracks, which this listing reads | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Document the omitted
FORWARDcase.For draft 19 and later, omitting
FORWARDhas the same forwarding behavior asFORWARD=1; both forms receivePUBLISH_SKIPPED. Include the omitted-parameter case in this Goal and its tests.🤖 Prompt for AI Agents