Repository navigation
fix(net)!: bound timestamps to 2^61 - 1 so lite-05/06 can carry every one #6168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
c86405e
quest: claim m1/lite-time-provenance
kixelated 5d7fb8a
feat(lite): carry unverified timestamps so receivers check verified t…
kixelated 3225bfe
Merge origin/main
kixelated 62e8288
feat(lite): drop lite-05/06 timestamps instead of flagging them
kixelated 4cc896f
Merge remote-tracking branch 'origin/main' into quest/m1/lite-time-pr…
kixelated c4700ab
quest: claim quest/m1/lite06-max-sequence
kixelated 10ad2aa
fix(net)!: bound timestamps to 2^61 - 1 so lite-05/06 can carry every…
kixelated 4d31d73
fix(net): keep the timestamp bound private to the model
kixelated 6aa6957
test: expect lite-05/06 subscribers to drop timestamps
kixelated 4f51deb
docs(net): link the timestamp bound's migration to its PR
kixelated 5ca875f
Merge remote-tracking branch 'origin/main' into merge-6150
kixelated 3f869eb
quest: point arrival-stamps at moq-dev/moq#6150 for the completed pro…
kixelated 987c451
Merge remote-tracking branch 'origin/main' into merge-6150-b
kixelated 409c75c
test: expect lite-05/06 subscribers to drop received timestamps
kixelated c2ed5f9
Merge remote-tracking branch 'origin/main' into merge-6150-b
kixelated 2c5a6ed
quest: point resume-outage links at moq-dev/moq#6183
kixelated 4758a60
Merge remote-tracking branch 'origin/main' into pr6150
kixelated 4a58ec5
fix(lite): stamp an unchecked track with its send time on lite-05/06
kixelated 8c3fa6f
Merge remote-tracking branch 'origin/main' into pr-6168
kixelated c2c1ef4
Merge remote-tracking branch 'origin/main' into pr6150
kixelated 65f7bc8
Merge remote-tracking branch 'origin/main' into pr6150
kixelated 7b8b4cf
Merge remote-tracking branch 'origin/main' into m6168
kixelated f2aa97f
Merge #6150 (drop lite-05/06 timestamps) into #6168
kixelated 44144fa
Merge remote-tracking branch 'origin/main' into quest/m1/lite-time-pr…
kixelated f0f4517
Merge remote-tracking branch 'origin/main' into pr6168
kixelated ea90447
Merge commit '44144fa75d3d2588588951a872782dc4853d5646' into pr6168
kixelated dfed0f2
docs: note the 2^61 - 1 timestamp bound in each binding's MIGRATE
kixelated 23a7e64
Merge remote-tracking branch 'origin/main' into worktree-agent-abce69…
kixelated aa850a4
quest: drop lite07-finalize's wait on the timestamp bound
kixelated 7f831eb
Merge remote-tracking branch 'origin/main' into worktree-agent-abce69…
kixelated 115f58d
Merge remote-tracking branch 'origin/main' into fix-6168
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Give Go callers a representable clamp.
A frame timestamp is a
*time.Duration(Lines 198-201).2^61 - 1microseconds exceeds the range of that nanosecond-based type. If a caller follows this instruction when converting unbounded microseconds totime.Duration, the conversion overflows before the write. Specify a clamp that also respects thetime.Durationrange, and distinguish it from the Rust timestamp bound.🤖 Prompt for AI Agents