Repository navigation
perf(net)!: box the transport so the session code compiles once #6176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
7fe39e5
quest: claim quest/m1/net-erase-transport.md
kixelated f80321e
perf(net)!: box the transport so the session code compiles once
kixelated 3875c15
docs: migrate notes for the boxed transport
kixelated 17c4f75
fix(net): keep the accept futures small
kixelated 5118d1f
quest: complete net-erase-transport
kixelated 988657d
docs: link the boxed transport PR
kixelated 6c1d87a
Merge remote-tracking branch 'origin/main' into merge-6176
kixelated 1efb8e8
docs(uring): name every removed _lite entry point in MIGRATE.md
kixelated 64bec98
Merge origin/main into quest/m1/net-erase-transport
kixelated 2bba60c
quest: point the compile-time audit at the merged moq-net change
kixelated f053257
test(net): drop the stale timescale argument from the SUBSCRIBE_DROP …
kixelated fbf0883
Merge origin/main into quest/m1/net-erase-transport
kixelated e3d3f37
Merge origin/main into quest/m1/net-erase-transport
kixelated fe1293c
fix(uring): forward wire counters through Local
kixelated 3861c1c
Merge origin/main into quest/m1/net-erase-transport
kixelated c582d41
Merge origin/main into quest/m1/net-erase-transport
kixelated 720731b
Merge origin/main into quest/m1/net-erase-transport
kixelated f54985a
Merge remote-tracking branch 'origin/main' into HEAD
kixelated 7de8028
Merge remote-tracking branch 'origin/main' into HEAD
kixelated 08e41c8
quest: drop the link to the finished net-erase-transport quest
kixelated eeef47c
Merge remote-tracking branch 'origin/main' into net-erase-transport
kixelated fe3816e
fix(net): carry streams_evicted through the boxed transport stats
kixelated ff2a960
Merge origin/main into quest/m1/net-erase-transport
kixelated 53cd844
Merge origin/main into quest/m1/net-erase-transport
kixelated 9a34ad8
Merge remote-tracking branch 'origin/main' into fix-6176
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Document the
SendStream::Groupbound.Boxablealso requires the session and eachSendStream::Groupto satisfy the nativeSendandSyncbounds. This note mentions only stream requirements, so custom transport authors can follow it and still fail atClient::connectorServer::accept_request. State the complete bound.Proposed wording
📝 Committable suggestion
🤖 Prompt for AI Agents