Repository navigation
chore(quest): finish the pinned consumer CLI flag migration - #6746
Conversation
Quest-Claim: 6c78ed38ab51e83b
Both pinned consumers are clear of every spelling #6522 renamed or removed: one already pins past it and uses the new names, the other pins before it but never passed an affected spelling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: d063c9a
No actionable bugs found in the two-file documentation change. Removing the completed quest together with its epic link is a minimal, coherent cleanup; no runtime, API, wire or build behavior changes.
Verification limits: inspected the complete diff and surrounding epic in moq-dev/moq. I did not independently verify downstream repository audits described in the PR, and did not run tests or quest/lint checks.
Problem
moq-dev/moq#6522 renamed or removed CLI flags, environment variables, and GStreamer properties with no aliases. The quest tracked moving each downstream deployment that pins moq at a commit past it, so the next release cut does not break their invocations.
Approach
Audited both consumers the API-audit epic names, at their current
main, for every spelling #6522 renamed or removed:--backoff-*,--goaway-*,MOQ_BACKOFF_*,MOQ_GOAWAY_*,MOQ_LISTEN_TLS_*/MOQ_SERVER_TLS_*/--tls-*onexport hls,--passthroughonimport fmp4/hls,--max-delayonexport rtmp,moqsrc versions=,moqsink linger, and<moq-publish linger>.--connect-backoff-timeout,MOQ_CONNECT_BACKOFF_TIMEOUT,--connect-version). No old spelling remains.lingerattribute. Its next routine pin bump needs no migration for this rename, so this PR does not bump it.--backoff-healthyfrom moq-dev/moq#6529 landed as--connect-backoff-healthy/MOQ_CONNECT_BACKOFF_HEALTHY; neither consumer uses it.The quest's Done condition (no pinned consumer passes a renamed or removed spelling) holds, so this deletes the quest and its epic link.
Notes for review:
MIGRATE.md's## Unreleasedheld the full list. It does not: per moq-dev/moq#6610, the notes are written at the breaking cut, and refactor(cli,gst,publish)!: align flags and drop the publisher linger opt-ins #6522's PR body carries them.moqsink linger; moq-dev/moq#6636 since reintroducedlingeras a duration in milliseconds (default 30000). Neither consumer sets it.Impact
Validation
just checkpassed (markdown, gh, quest, shell lint);quest check --base origin/mainpasses.maintrees (excluding vendored checkouts andnode_modules) for each old spelling, and confirmed the new spellings are in use where the flags appear.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code