Skip to content

chore(quest): finish the pinned consumer CLI flag migration - #6746

Merged
kixelated merged 2 commits into
mainfrom
quest/m1/api-audit/cli-flags-consumers
Oct 25, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/m1/api-audit/cli-flags-consumers

Conversation

@kixelated

@kixelated kixelated commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

moq-dev/moq#6522 renamed or removed CLI flags, environment variables, and GStreamer properties with no aliases. The quest tracked moving each downstream deployment that pins moq at a commit past it, so the next release cut does not break their invocations.

Approach

Audited both consumers the API-audit epic names, at their current main, for every spelling #6522 renamed or removed: --backoff-*, --goaway-*, MOQ_BACKOFF_*, MOQ_GOAWAY_*, MOQ_LISTEN_TLS_* / MOQ_SERVER_TLS_* / --tls-* on export hls, --passthrough on import fmp4/hls, --max-delay on export rtmp, moqsrc versions=, moqsink linger, and <moq-publish linger>.

The quest's Done condition (no pinned consumer passes a renamed or removed spelling) holds, so this deletes the quest and its epic link.

Notes for review:

Impact

  • Public API and wire: none. Quest files only.

Validation

  • just check passed (markdown, gh, quest, shell lint); quest check --base origin/main passes.
  • Searched both consumers' main trees (excluding vendored checkouts and node_modules) for each old spelling, and confirmed the new spellings are in use where the flags appear.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

kixelated and others added 2 commits October 24, 2026 23:51
Both pinned consumers are clear of every spelling #6522 renamed or
removed: one already pins past it and uses the new names, the other
pins before it but never passed an affected spelling.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Pinned consumers adopt the CLI flag names chore(quest): finish the pinned consumer CLI flag migration Oct 25, 2026
@kixelated
kixelated marked this pull request as ready for review October 25, 2026 06:55
@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6532c1a7-b0bf-4426-9ded-48ac5093930d
Commits

Reviewing files that changed from the base of the PR and between 67bf4e5 and d063c9a.

Files selected for processing: 2
  • quest/m1/api-audit/README.md
  • quest/m1/api-audit/cli-flags-consumers.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-25T06:55:19.171377Z d063c9a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: d063c9a

No actionable bugs found in the two-file documentation change. Removing the completed quest together with its epic link is a minimal, coherent cleanup; no runtime, API, wire or build behavior changes.

Verification limits: inspected the complete diff and surrounding epic in moq-dev/moq. I did not independently verify downstream repository audits described in the PR, and did not run tests or quest/lint checks.

@kixelated
kixelated added this pull request to the merge queue Oct 25, 2026
Merged via the queue into main with commit d2d7adc Oct 25, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m1/api-audit/cli-flags-consumers branch October 25, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant