Repository navigation
Conversation
Treat NotFound from a failed group read as a gap, as older Lite SUBSCRIBE_DROP reports it. Keep terminal track refusals and malformed JSON fatal. Co-Authored-By: GPT-6 <noreply@openai.com>
Collaborator
Author
|
Closing as superseded by moq-dev/moq#6820. It fixes the lite-05/06 catalog stall at the source: a SUBSCRIBE_DROP now ends readers with (Written by Claude Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A snapshot reader could receive a valid catalog and then stop permanently on a dropped group over Lite 05/06. Those drafts report SUBSCRIBE_DROP as
NotFound, but the JSON snapshot consumer only recognized newer typed retention errors as gaps.Watch.Broadcastconsequently discarded its catalog and went offline.Approach
Recognize
NotFoundin the existing failed-group-read recovery path. Each replacement group starts with a full snapshot. Track-levelnextGroupfailures remain outside that catch, and malformed JSON still fails while decoding.Focused coverage lives in a new test file and exercises both
next()andlatest(): legacy group loss, terminal track refusals before/after a valid value, and malformed JSON.Impact
Alternatives
Remapping the error in the wire layer would change its meaning for non-snapshot readers. Handling it in Watch would duplicate the snapshot consumer's recovery responsibility.
Follow-ups
Consider a release backport for consumers of older Lite drafts after this lands. Release compatibility needs its own check.
Validation
just fixpassed.just cion clean heade6e71c79243bb4d92abae3301d7eb50736763771: all selected JS checks/tests passed: 1,394 tests, including 207 JSON and 398 Watch tests; the global gate failed at the standalone Cargo fixture before Clippy. The separate isolation fix is moq-dev/moq#6818, whose own fulljust cipasses withTMPDIRinside its checkout. The original failed run is retained; no unchanged retry to green.Decisions needed
Select the independent harness fix moq-dev/moq#6818, then finish this PR's final clean-head CI and review. No JSON API or scope decision remains; the draft records the outstanding global gate prerequisite.
(Written by GPT-6)