Skip to content

quest: retire the completed Windows Nightly build fix - #6848

Closed
kixelated wants to merge 2 commits into
mainfrom
quest/m0/nightly/windows-relay-expect
Closed

kixelated wants to merge 2 commits into
mainfrom
quest/m0/nightly/windows-relay-expect

Conversation

@kixelated

@kixelated kixelated commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The Windows Nightly quest still appears ready even though moq-dev/moq#6821 already fixed all three failures on main.

Approach

Remove the completed quest and its prerequisite link from the Nightly epic. Verified the merged source scopes the relay lint expectation to its callers, gates Read::Idle to Linux, and gates I420::from_bgra to Linux with PipeWire.

The fix's Platform dispatch passed both Windows and macOS.

Impact

  • No public API or wire changes. Quest bookkeeping only.

Alternatives

Duplicating the already merged implementation would add no behavior.

Validation

  • quest check --base origin/main: 580 documents pass.
  • just ci: pass (39 s).

Follow-ups

The remaining Nightly failures retain their existing quests.

(Written by GPT-6)

@kixelated kixelated changed the title Windows builds moq-relay's tests quest: retire the completed Windows Nightly build fix Oct 26, 2026
Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review October 26, 2026 04:11
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cfefd55e-9bb9-4c22-acfb-8fb63f433421
Commits

Reviewing files that changed from the base of the PR and between de425d5 and dd7436d.

Files selected for processing: 2
  • quest/m0/nightly/README.md
  • quest/m0/nightly/windows-relay-expect.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T04:12:47.670777Z dd7436d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: dd7436d

No actionable bugs found. Retiring this completed quest and its prerequisite link is appropriate: #6821 is merged, and the current source contains the scoped relay lint expectations, Linux-only Read::Idle, and Linux/PipeWire-only I420::from_bgra. The Nightly epic still retains its remaining children and explicit scheduled-run verification, so this does not declare the whole Nightly effort complete. Removing stale work is simpler than duplicating the implementation.

Verification: static inspection of both changed documents, merged #6821, and the relevant current source; no builds, tests, or CI reruns performed.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: Codex reviewed head dd7436d with no findings (thumbs up); the OpenAI review comment found nothing actionable. CI is green (11/11). quest check --base origin/main passes on the head (580 documents). No decisions were needed; the diff only deletes the finished quest and its link from the Nightly epic, since moq-dev/moq#6821 already landed the fix. Landing via the merge queue (squash).

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 26, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Oct 26, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Requeueing after the merge queue dropped this on checks_timed_out (queue overload; the PR's own checks pass). No changes: head dd7436dcde540677941e692959a16e1789daa679 is unchanged, Codex reacted with no findings, the automated review found nothing actionable, and quest check --base origin/main passes (580 documents). No decisions outstanding.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 26, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 26, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Superseded by #6833, which already deleted this quest and its link from main.

(Written by Claude Opus 5.5)

@kixelated kixelated closed this Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant