Skip to content

fix(moq-mux): sweep the catalog write-order bench without the removed rendition cap - #6911

Merged
kixelated merged 1 commit into
mainfrom
fix/moq-mux-bench-max-renditions
Oct 27, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/moq-mux-bench-max-renditions

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

rs/moq-mux/benches/catalog.rs sweeps [1, 16, hang::catalog::MAX_RENDITIONS], but moq-dev/moq#6827 removed that constant. moq-dev/moq#6784 landed the bench use afterwards, so every Rust bench build (--all-targets, just bench) fails on main.

Approach

Sweep the former cap's value (64) as a literal, matching the sibling UNRESOLVED sweep, and drop the comment's reference to a cap that no longer exists. The benchmark keeps its 1 / 16 / 64 shape and IDs, so history stays comparable.

cargo check --workspace --all-targets is otherwise clean.

Impact

  • No public API or wire change.

Follow-ups

  • The merge gate compiles only --tests (nextest and the feature-extreme clippy), never --benches, so a semantic conflict in a bench reaches main.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

… rendition cap

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: d05f628

No actionable bugs found. The change in rs/moq-mux/benches/catalog.rs:225-226 is appropriately narrow: a fixed benchmark sweep removes the dependency on the deleted rendition-cap API, while leaving the write-order workload and parameter-derived benchmark IDs unchanged. Keeping the literal in this benchmark is simpler than restoring a production constant solely for a fixture.

Verification: inspected the diff, full benchmark and current catalog module; no prior reviews or inline findings were present. I did not run builds, tests or benchmarks, so this is not confirmation that the reported all-targets check passes.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 752e5318-55f5-4c3c-b70d-8239b3b435e8
Commits

Reviewing files that changed from the base of the PR and between 06c58c7 and d05f628.

Files selected for processing: 1
  • rs/moq-mux/benches/catalog.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Landing d05f628 at the front of the queue (maintainer-approved jump) to unbreak Rust bench builds on main. The automated OpenAI review on this head found nothing; Codex did not respond within 40 minutes. Local cargo clippy -p moq-mux -p hang --all-targets --all-features -D warnings and cargo check --workspace --all-targets pass.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 27, 2026
@kixelated
kixelated removed this pull request from the merge queue due to a manual request Oct 27, 2026
@kixelated
kixelated added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit 8862064 Oct 27, 2026
10 checks passed
@kixelated
kixelated deleted the fix/moq-mux-bench-max-renditions branch October 27, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant