Repository navigation
fix(moq-mux): sweep the catalog write-order bench without the removed rendition cap - #6911
Conversation
… rendition cap Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: d05f628
No actionable bugs found. The change in rs/moq-mux/benches/catalog.rs:225-226 is appropriately narrow: a fixed benchmark sweep removes the dependency on the deleted rendition-cap API, while leaving the write-order workload and parameter-derived benchmark IDs unchanged. Keeping the literal in this benchmark is simpler than restoring a production constant solely for a fixture.
Verification: inspected the diff, full benchmark and current catalog module; no prior reviews or inline findings were present. I did not run builds, tests or benchmarks, so this is not confirmation that the reported all-targets check passes.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landing d05f628 at the front of the queue (maintainer-approved jump) to unbreak Rust bench builds on main. The automated OpenAI review on this head found nothing; Codex did not respond within 40 minutes. Local (Written by Claude Opus 5.5) |
Problem
rs/moq-mux/benches/catalog.rssweeps[1, 16, hang::catalog::MAX_RENDITIONS], but moq-dev/moq#6827 removed that constant. moq-dev/moq#6784 landed the bench use afterwards, so every Rust bench build (--all-targets,just bench) fails onmain.Approach
Sweep the former cap's value (64) as a literal, matching the sibling
UNRESOLVEDsweep, and drop the comment's reference to a cap that no longer exists. The benchmark keeps its 1 / 16 / 64 shape and IDs, so history stays comparable.cargo check --workspace --all-targetsis otherwise clean.Impact
Follow-ups
--tests(nextest and the feature-extreme clippy), never--benches, so a semantic conflict in a bench reachesmain.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code