Skip to content

quest: plan follow-ups from the 2026-10-27 PR pass - #6944

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/followups-6941
Oct 28, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/followups-6941

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Plans the follow-ups from the 2026-10-27 /quest-complete pass through /quest-plan.

New quests

m0:

m1:

Edits

  • quest/m1/api-audit/strict-paths.md grows to [M]: Path refuses a non-canonical escape so the moq-transport namespace mapping round-trips (from moq-dev/moq#6927).

Not planned

Decisions

Scope

  • IntoFuture + JS frames ✅
  • Smoke + switch latency ✅
  • Path escapes ✅
  • Release backports ✅

Incoming IntoFuture (first prompt answered "Either is gross, wtf is that? And why moq-tokio?", re-asked with context)

  • Delete the impl ✅
  • Reuse Connecting

Frame bound

  • Backpressure, both langs ✅
  • Count cap, both langs
  • JS only

Smoke

  • Released API only ✅
  • Pin per client
  • Go/C only

Catch-up

  • Drop the old tail ✅
  • Faster slew
  • Accept it

Escapes (first prompt answered "we need to fix to_tuple and from_tuple so they're symettrical?", re-asked with the canonical-spelling constraint)

  • to_tuple refuses
  • Path refuses ✅

Backports

Priority demotion

  • Bullet in the latency quest ✅
  • Separate quest
  • Drop it

Bound backport

  • No, ship in next cut ✅
  • Yes, m0 backport

Docs

  • No new pages ✅
  • Add a docs quest

Impact

Quest files only. Public API: none. Wire: none.

Checks

quest check passes.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Adds five quests (Incoming IntoFuture, container backpressure, Smoke on
released APIs, stitch catch-up, frame-start backport) and folds canonical
path escapes into strict-paths.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a0906299-294d-47ee-977b-b6dbcb9ef9cb
Commits

Reviewing files that changed from the base of the PR and between ee5ac74 and 172ce95.

Files selected for processing: 11
  • quest/m0/README.md
  • quest/m0/backport-frame-start.md
  • quest/m0/smoke-released.md
  • quest/m1/README.md
  • quest/m1/api-audit/README.md
  • quest/m1/api-audit/strict-paths.md
  • quest/m1/container-backpressure.md
  • quest/m1/quic-api/README.md
  • quest/m1/quic-api/incoming-future.md
  • quest/m1/ts-reliability/README.md
  • quest/m1/ts-reliability/stitch-catch-up.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T23:34:14.017366Z 172ce95 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)
Reviewed commit: 172ce95

No actionable bugs found in this quest-only change. The direction is coherent: keep Smoke on released APIs without weakening freshness, backport the narrow JS refusal rather than the new storage model, remove Incoming's unnecessary future adapter, and make canonical paths symmetric. The backpressure and stitch-catch-up plans appropriately track remaining limitations rather than claiming the earlier PRs fixed them.

Implementation guardrails: the consumer budget should account for retained sample/group overhead and preserve delivery-head progress when later groups consume capacity; test those alongside the planned same-timestamp/many-group cases. Keep repeated-switch monotonicity checks when dropping the old tail.

Verification: static inspection of the plans and relevant consumer, namespace, Incoming, jitter, and Smoke code only. I did not run quest checks, tests, Smoke, or release/backport validation; these runtime fixes remain future work.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary for head 172ce95:

  • Codex reviewed this head with no findings, and the automated review on this head found no actionable bugs.
  • quest check --base origin/main passes (614 documents).
  • No changes made during merge. I did not fold in the review's implementation guardrails (count retained sample and group overhead in the consumer budget, keep the delivery head moving, keep monotonicity checks across repeated switches). They are notes for whoever implements those quests, not errors in the plans, and they would only add another review round.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit e5b84dd Oct 28, 2026
10 checks passed
@kixelated
kixelated deleted the quest-plan/followups-6941 branch October 28, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant