Skip to content

quest: plan CLI media modes and the resolve follow-ups - #7205

Merged
kixelated merged 3 commits into
mainfrom
quest-plan/followups-1029b
Oct 29, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest-plan/followups-1029b

Conversation

@kixelated

@kixelated kixelated commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Plans the follow-ups held from this session's merges.

Quests

  • quest/m1/eager-encode/cli-modes.md [S]:
    • moq import capture takes --video <on|demand|off> and --audio <on|demand|off>, replacing --no-video, --no-audio and --on-demand (from moq-dev/moq#7188).
    • export and play take --video/--audio <on|off> in place of --no-*.
    • Raw audio later adds buffered to --audio.
  • quest/m2/release/smoke-bindings-rename.md [XS]: a waiting quest. Once a binding release ships request/follow, the native smoke clients move to them.
  • quest/m2/hls-follow-once.md [S]: Following reports synced absence, so moq-hls resolves with one follow (from moq-dev/moq#7192).
  • quest/m2/bench-epoch-pin.md [XS]: moq-bench pins pooled requests to their announced epoch.
  • Plan notes on existing quests:
    • migrate-audit.md: correct overturned Unreleased entries, starting with js/net's announced note.
    • raw-audio.md: the CLI's audio mode gains buffered as its default.
    • land.md: the gate must test each PR on the latest main. moq-dev/moq#7162 broke in the queue on renames its own CI never saw.

Decisions

  • CLI flags:
    • ✅ --video/--audio with on|demand|off in capture and on|off in export and play
    • --on-demand kept
    • --video-encode / --audio-encode
    • --video-enabled / --audio-enabled
    • always, never or none as values
  • Stale js/net/MIGRATE.md:
    • ✅ Fold into migrate-audit
    • A separate [XS] fix
  • CLI help after raw audio:
    • ✅ Superseded by the CLI modes quest, plus a raw-audio Plan line
  • Lite publisher yield after SUBSCRIBE_UPDATE (from moq-dev/moq#6988):
    • ✅ Dropped, since nothing user-visible depends on it
    • An [S] m2 quest
  • Land gate note:
    • ✅ Add to land.md
    • Skip
  • Smoke clients:
    • ✅ An [XS] waiting quest in the m2 release epic
    • Fold into cut.md
  • C route epochs:
  • moq-hls double resolve:
    • ✅ An [S] m2 quest
    • m1 in the resolve epic
    • Drop
  • moq-bench epoch pin:
    • ✅ An [XS] m2 quest
    • Drop

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

CLI `--video`/`--audio` take on|demand|off, C routes carry their epoch,
smoke clients wait on the binding release, moq-hls follows once, moq-bench
pins epochs, plus Plan notes in migrate-audit, raw-audio and land.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 24 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5882df31-d533-4ff9-ad27-89d52b90c738
Commits

Reviewing files that changed from the base of the PR and between 66bdbb9 and fef89a6.

Files selected for processing: 10
  • quest/m0/ci/land.md
  • quest/m1/eager-encode/README.md
  • quest/m1/eager-encode/cli-modes.md
  • quest/m1/eager-encode/raw-audio.md
  • quest/m2/README.md
  • quest/m2/bench-epoch-pin.md
  • quest/m2/hls-follow-once.md
  • quest/m2/release/README.md
  • quest/m2/release/migrate-audit.md
  • quest/m2/release/smoke-bindings-rename.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T15:26:13.548396Z fef89a6 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 50913ca

No actionable planning bugs found. The CLI modes retain the distinction between capture demand and export/play selection, and the raw-audio coordination handles either landing order. The route-epoch and HLS follow-once goals match the current receiving-route and discovery gaps; pooled benchmark requests currently discard announcement epochs. Smoke-client migration is appropriately conditional on published packages, while migration-guide corrections remain with the release audit.

Direction: these are focused follow-ups with existing consumers. Keeping absent-path reporting nonterminal for Following avoids turning a reusable follower into a one-shot request. No extra implementation detail is needed in these plans.

Verification: static review of the plans, repository review guidance, and relevant CLI, origin, HLS, benchmark, C/FFI route, and smoke-policy code/docs. No tests or builds run; future implementations and release availability were not verified.

(Written by OpenAI)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: the plans settled through /quest-plan land unchanged at 50913ca.

  • Reviews of this head: Codex 👍 (no findings), and the automated OpenAI review found no actionable issues.
  • quest check (against origin/main) and sh/markdown.sh check pass locally.
  • No findings to fix and no follow-up decisions.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 29, 2026
kixelated and others added 2 commits October 29, 2026 08:24
#7151 landed on main and already fills moq_route's epoch for
every received announcement, so the planned receiving-side quest has no
work left.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: landing fef89a6, after it left the queue on merge_conflict.

  • Merged main in. The quest merge driver resolved the link-list conflicts.
  • Dropped quest/m1/c/route-epoch.md with quest rm. moq-dev/moq#7151 landed on main and removed announce-route.md, which this quest linked to. Its receiving side already fills moq_route.epoch for every announcement it receives, which was this quest's whole goal. The PR body's decision list records the drop.
  • Review of this head: Codex 👍 (no findings).
  • quest check against the latest origin/main and sh/markdown.sh check pass locally.

Suggested follow-up (not planned): a moq-c test that pins a request to a received route's epoch and checks that it refuses another instance. Today's tests pin only Rust-minted epochs.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 29, 2026
Merged via the queue into main with commit b45210d Oct 29, 2026
11 checks passed
@kixelated
kixelated deleted the quest-plan/followups-1029b branch October 29, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant