Repository navigation
quest: plan CLI media modes and the resolve follow-ups - #7205
Conversation
CLI `--video`/`--audio` take on|demand|off, C routes carry their epoch, smoke clients wait on the binding release, moq-hls follows once, moq-bench pins epochs, plus Plan notes in migrate-audit, raw-audio and land. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 24 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 50913ca
No actionable planning bugs found. The CLI modes retain the distinction between capture demand and export/play selection, and the raw-audio coordination handles either landing order. The route-epoch and HLS follow-once goals match the current receiving-route and discovery gaps; pooled benchmark requests currently discard announcement epochs. Smoke-client migration is appropriately conditional on published packages, while migration-guide corrections remain with the release audit.
Direction: these are focused follow-ups with existing consumers. Keeping absent-path reporting nonterminal for Following avoids turning a reusable follower into a one-shot request. No extra implementation detail is needed in these plans.
Verification: static review of the plans, repository review guidance, and relevant CLI, origin, HLS, benchmark, C/FFI route, and smoke-policy code/docs. No tests or builds run; future implementations and release availability were not verified.
(Written by OpenAI)
|
Merge summary: the plans settled through
(Written by Claude Opus 5.5) |
#7151 landed on main and already fills moq_route's epoch for every received announcement, so the planned receiving-side quest has no work left. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge summary: landing fef89a6, after it left the queue on
Suggested follow-up (not planned): a moq-c test that pins a request to a received route's epoch and checks that it refuses another instance. Today's tests pin only Rust-minted epochs. (Written by Claude Opus 5.5) |
Plans the follow-ups held from this session's merges.
Quests
quest/m1/eager-encode/cli-modes.md[S]:moq import capturetakes--video <on|demand|off>and--audio <on|demand|off>, replacing--no-video,--no-audioand--on-demand(from moq-dev/moq#7188).exportandplaytake--video/--audio <on|off>in place of--no-*.bufferedto--audio.quest/m2/release/smoke-bindings-rename.md[XS]: a waiting quest. Once a binding release shipsrequest/follow, the native smoke clients move to them.quest/m2/hls-follow-once.md[S]:Followingreports synced absence, so moq-hls resolves with one follow (from moq-dev/moq#7192).quest/m2/bench-epoch-pin.md[XS]: moq-bench pins pooled requests to their announced epoch.migrate-audit.md: correct overturned Unreleased entries, starting with js/net'sannouncednote.raw-audio.md: the CLI's audio mode gainsbufferedas its default.land.md: the gate must test each PR on the latestmain. moq-dev/moq#7162 broke in the queue on renames its own CI never saw.Decisions
--video/--audiowithon|demand|offin capture andon|offin export and play--on-demandkept--video-encode/--audio-encode--video-enabled/--audio-enabledalways,neverornoneas valuesjs/net/MIGRATE.md:main, fillsmoq_route's epoch for every received announcement🤖 Generated with Claude Code
(Written by Claude Opus 5.5)