Repository navigation
quest: delete hls-lazy-instances, moot after #7399 - #7227
Conversation
Quest-Claim: cd0cdebafcfcb6c2
|
Closing this stale claim at the maintainer's request: it has held only the empty claim commit since 2026-10-29, with no work pushed. Closing it and deleting the branch frees the quest for a later (Written by Claude Opus 5.5) |
The session that claimed this quest stopped before committing. This preserves its uncommitted changes as found on 2026-11-02; they are unfinished and unreviewed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reopened: the claim looked empty on GitHub, but its local worktree held uncommitted work from the 2026-10-29 session. That work is now pushed as checkpoint d157398 and marked unfinished under (Written by Claude Opus 5.5) |
kixelated
changed the title
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title names the change: it deletes the hls-lazy-instances quest document and states that it is moot after #7399. The raw summary confirms the README entry removal and the document deletion, so the… |
| Description check | |
The description explains the deletion of quest/m2/hls-lazy-instances.md and the removal of its README entry. It gives the reason (PR #7399 already stops the replaced instance's watchers), the revert o… |
| Docstring Coverage | |
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Title check
-
Explanation
The title names the change: it deletes the hls-lazy-instances quest document and states that it is moot after
#7399. The raw summary confirms the README entry removal and the document deletion, so the title matches the changeset.
Full details: Description check
-
Explanation
The description explains the deletion of quest/m2/hls-lazy-instances.md and the removal of its README entry. It gives the reason (PR
#7399already stops the replaced instance's watchers), the revert of the WIP checkpoint, and the review scope. It relates directly to the changeset.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.
Finishing Touches
-
Simplify code
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 88aabae
No actionable bugs found. The diff only deletes the lazy-retained-instance quest and its index entry; no runtime, API, or wire changes remain. The direction is simpler and consistent with the existing takeover path: Followed::start calls replaced(), which cancels catalog watching and cuts rendition record watchers. Reintroducing request-triggered watcher restarts would work against that frozen-window behavior.
Verification: static review of the two-file diff and relevant takeover, watcher ownership, and rendition-cut code. No prior published review findings were present. I did not run tests, quest validation, or measure retained-instance resource usage.
(Written by OpenAI)
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
This run reviewed a quest-only deletion. Removes quest/m2/hls-lazy-instances.md and its bullet from quest/m2/README.md; no code or wire changes.
- Quest deleted —
quest/m2/hls-lazy-instances.md(Retained HLS instances watch only when read) is removed. - Index bullet removed — the
quest/m2/README.md## Requiredentry is dropped, leavingQoSadjacent toHLS and DASH browser playback.
Verified against the tree: no repo-wide hls-lazy-instances references remain, the index bullet is removed cleanly, and the cited clearing PR #7399 (MERGED 2026-11-01, 35967e89d) does the takeover cleanup the quest asked for. Followed::start calls Broadcaster::replaced() (rs/moq-hls/src/server/mod.rs:139-148), replaced() drops the catalog watcher and cuts every rendition (rs/moq-hls/src/export/mod.rs:442-446), and each rendition's cut() drops its record watcher (rs/moq-hls/src/export/rendition.rs:671-675). A quest deletion plus its milestone-README link removal is the established completion convention, so no findings.
deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏
Summary
Deletes quest/m2/hls-lazy-instances.md as moot, and removes its entry from
quest/m2/README.md. The diff againstmaincontains only this deletion.The quest's goal was that a replaced HLS instance stops watching its publisher. Merged PR moq-dev/moq#7399 already does that on takeover:
Followed::startcallsBroadcaster::replaced()on the instance it replaces (rs/moq-hls/src/server/mod.rs:139-148).replaced()drops the catalog watcher and cuts every rendition (rs/moq-hls/src/export/mod.rs:442-446).rs/moq-hls/src/export/rendition.rs:671-675).A retained instance therefore no longer runs a catalog or record watcher. It still holds its frozen window and one idle driver future with no subscriptions. Both are small, and they are bounded by the broadcasts the publisher keeps open, as the quest's own Plan said.
The 2026-10-29 WIP checkpoint (d157398e57) is reverted. It rebuilt a replaced instance's broadcaster when a request arrived. That restarts its watchers and lets an ended (
EXT-X-ENDLIST) playlist grow again, which undoes #7399.The maintainer decided to delete the quest on 2026-11-02, choosing option 1 from this PR's earlier
## Decisions needed.Review
Skipped. This is a quest-only deletion:
git diff origin/main...HEADtouches onlyquest/m2/hls-lazy-instances.md(deleted) and one link line inquest/m2/README.md, and it changes no code.quest check --base origin/mainpasses (574 documents ok). Head: 88aabae.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)