Repository navigation
quest: restart the capped-budget count after the history-fill fix - #7286
Conversation
Quest-Claim: d9bd610d15dbd882
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: f4bf5e8
No actionable bugs found in this documentation-only change. Restarting the seven-night measurement window after the history-fill fix is a sound direction: it avoids calibrating budgets against the known over-fetch, preserves the earlier observations, and leaves the existing ceilings unchanged until enough post-fix data exists. No additional implementation complexity is introduced.
Verification: inspected the complete diff, surrounding quest plan, current budget rules/ceilings, and the referenced #7168 fix. No prior published review findings to carry forward. I did not run tests or independently reproduce the nightly trace analysis; the reported measurements are not independently validated here.
Progress on
quest/m1/audio-jitter-target/capped-budgets.md. Five of the seven scheduled nightlies since 2026-10-25 have run.budgets.jsonis unchanged: the Plan says to re-measure only from seven nights, and the first four of these measured a relay bug.Findings
fixed-250and Opusnear-zero, the subscriber received 15 to 25 s of the publisher's cached history, newest first. On thewiderows the estimator treated it as a late interval, held a 2020 ms target for about 20 s, then discarded 1.8 to 1.9 s of audio a minute falling back. That happened on all four nights, so it is the 10-28 AAC/Opuswidebreach. The 10-28 Opusbursty540 ms target lines up with the same arrival at 4.5 s. Nowideorburstyrow logged more than one long task (at most 58 ms), so these are not runner stalls.widediscarded 205.6 ms/min at a 323.2 ms target p95, and Opuswide243.4 at 460.burstydiscarded 0 to 238.1 ms/min against Opusbursty's 0 to 370.9. Opusnear-zerohad no underrun episodes. Its target p95 was 60 ms on three nights and 80 on two, because the 120 ms prior only decays to 60 at 21.4 s, after the 5 s warmup. The Plan says to budget that startup hold as measured.Changes
quest/m1/audio-jitter-target/capped-budgets.md: records the history-fill finding, the restarted count (1 of 7, from 2026-10-29), and the 2026-10-29 goal readings, and points here for the per-night data. I did not touchbudgets.json.Decisions
Follow-ups
Checks
quest check --base origin/main: passed onf4bf5e8f7a.just check: not rerun onf4bf5e8f7a; that commit only edits quest prose.quest gate just check: passed (markdown, gh, quest, shell, toml, nix, justfile).Review
f4bf5e8f7a8a7fa917ddb2d0e84a2af4798dc3d4: review skipped as trivial. The commit only records the maintainer's restart decision in the quest prose.quest review --base origin/main, round 1), on8add6f8e107849e2fa4ef1f05ed7ce34830fd7ed. No findings.Per-night browser metrics, 2026-10-25 to 10-29 (the artifacts expire after 7 days)
Runs: 10-25 40192013303, 10-26 40332938121, 10-27 40506938673, 10-28 40698329026, 10-29 40885347517. No row voided.
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)