Repository navigation
test(audio): a latest join loses no group a publisher bursts before its first frame - #7342
Conversation
Quest-Claim: cfcffc285d26c2ad
…ts first frame #6990 already subscribes a Start::Latest join with its whole budget from the start, so the remaining work in quest/m2/audio-join-budget.md was the session-level reproduction its Plan asks for. The test bursts one-packet groups over a memory session before the first decode and fails with a 320 ms gap if the wire budget is narrowed to the warmup again. Finishes and deletes the quest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 1 minute. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit ff68d09.
No actionable findings. The new regression exercises the existing full subscription budget over a lite-07 memory session: the synchronous burst precedes the first decode, the oracle rejects every gap and requires the complete 80–400 ms timestamp sequence after warmup. Keeping this focused regression rather than reworking the already-fixed production path is the right direction.
The separately disclosed capped-stream-credit/Old-reset scenario remains useful follow-up coverage; this test does not establish it. Static GitHub review only, including the existing Consumer initialization, warmup handling and link helper; I did not run tests or verify the reported mutation/gate results.
(Written by OpenAI)
|
Landing summary: the head ff68d09 adds a transport-level regression test ( (Written by Claude Opus 5.5) |
Finishes
quest/m2/audio-join-budget.md. This PR deletes the quest and its links fromquest/m2/README.mdandquest/m2/readers-range-live.md.Summary
The fix in the quest's Plan already landed in moq-dev/moq#6990. Since then, a
Start::Latestjoin subscribes withmax_delay + warmupfrom the start and moves only its local cursor to the live edge, and thejoining_latestnarrowing is gone. That PR didn't delete this quest. Its test checks the subscription budget in-process, and it listed a transport-level test as a follow-up.This PR adds the reproduction the Plan asks for, over
moq_net::transport::memory.latest_loses_no_group_the_publisher_bursts_before_its_first_frameinrs/moq-audio/src/decode/consumer.rsworks like this:Start::Latestconsumer joins across a lite-07 session, with an 80 ms catalog warmup and a 1 s budget.Read::Gapand that every frame from the end of the warmup (80 ms) to 400 ms arrives.I confirmed it reproduces the bug. With the wire budget narrowed to the warmup again for a Latest join (the shape before #6990), the test fails with
a gap of 320ms after 0s. On main it passes.Choices made without asking
linkhelper in moq-audio's tests and doesn't needLink::held: the burst happens before the first decode, so no out-of-order delivery is needed.Checks
quest gate just check: passed (rs check and tests, rs_shapes, markdown, gh, shell, quest, ...).quest check --base origin/main: 665 documents ok.Review
quest review), gpt-6.1-sol, medium effort.Suggested follow-ups
Oldresets within its budget. This test exercises the publisher's skip on the wire budget, not relay-side stream-credit resets.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code