Repository navigation
chore(nix): pin quest at 7a191e6 - #7511
Conversation
The old pin (1ef2ca7, 2026-10-30) predates moq-dev/quest#306, so a `quest merge --land` re-pick after a push asked GitHub to enable auto-merge again, GitHub kept the old request and its stale Quest-Land-Head, and the land gate ejected the PR as head_moved. 7a191e6 is the commit the host land gate already runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title states the main change: the dev shell's quest input is pinned to commit 7a191e6. The raw summary confirms that flake.nix now points the quest input to revision 7a191e6 instead of b1f0c40. Th… |
| Description check | |
The description states that the dev shell's quest pin moves to moq-dev/quest@7a191e6 from the older 1ef2ca7 pin. It explains the reason (quest#306 and the head_moved ejection) and lists the checks run… |
| Docstring Coverage | |
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Title check
-
Explanation
The title states the main change: the dev shell's quest input is pinned to commit 7a191e6. The raw summary confirms that flake.nix now points the quest input to revision 7a191e6 instead of b1f0c40. The title uses the conventional chore(nix) prefix and is specific.
Full details: Description check
-
Explanation
The description states that the dev shell's quest pin moves to moq-dev/quest@7a191e6 from the older 1ef2ca7 pin. It explains the reason (quest#306 and the head_moved ejection) and lists the checks run. This matches the flake.nix change in the raw summary, so it is related to the changeset.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Finishing Touches
-
Simplify code
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
kixelated
left a comment
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: f9b2e65
No actionable bugs found. The flake input and locked revision agree, and the selected Quest revision includes the disable/re-enable behavior that refreshes stale landing-head pins. Its default package still supplies the CLI on all three systems used here.
Direction: upgrading the pinned tool is the simpler fix than duplicating its queue logic locally. No MoQ API or wire changes.
Verification: static inspection of both changed files, their consumers, and the selected dependency's packaging and enqueue implementation. I did not run Nix builds or tests, recompute the NAR hash, or verify the live host gate's installed revision.
(Written by OpenAI)
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Pin
questat7a191e6— bumps the dev-shell flake input inflake.nixand itsflake.lockentries (rev+original.rev, plusnarHash/lastModified), from1ef2ca7to7a191e6.
The bump is internally consistent (flake.nix URL and both flake.lock revs agree), and I confirmed against moq-dev/quest that 7a191e6 is a valid signed commit and that compare/1ef2ca7...7a191e6 is ahead by 38 commits with behind_by: 0 — a clean forward move that includes moq-dev/quest#306 (the re-pin fix this depends on). No other pin of the quest rev exists in the repo.
deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏
|
quest land removed this pull request from the queue: the batch check failed (exit 1). Compiling iana-time-zone v0.1.65
Compiling camino v1.2.6
Checking smol_str v0.2.2
Checking dpi v0.1.2
Compiling winnow v0.7.15
Compiling cbindgen v0.29.4
Checking pollster v1.0.1
Compiling toml v0.9.12+spec-1.1.0
Compiling chrono v0.4.45
Checking glib v0.22.10
Compiling clap v4.6.7
Compiling uniffi_pipeline v0.32.2
Compiling gstreamer-audio-sys v0.25.4
Checking option-operations v0.6.1
Checking kstring v2.0.5
Checking mp4ra-rust v0.3.0
Checking socket2 v0.5.10
Checking mpeg4-audio-const v0.2.0
Checking ryu v1.0.23
Compiling convert_case v0.4.0
Checking mime v0.3.17
Checking web-time v1.1.0
Compiling paste v1.0.15
Checking muldiv v1.0.1
Compiling derive_more v0.99.20
Checking axum-core v0.5.6
Checking serde_urlencoded v0.7.1
Checking gstreamer v0.25.4
Checking rfc6381-codec v0.2.0
Compiling uniffi_meta v0.32.2
Checking smithay-clipboard v0.7.3
Compiling gst-plugin-version-helper v0.8.4
Checking str0m-aws-lc-rs v0.6.0
Checking is v0.11.1
Checking arboard v3.7.0
Checking sctp-proto v0.10.5
Checking sha1 v0.10.7
Checking sha-1 v0.10.1
Checking pbkdf2 v0.12.2
Checking type-map v0.5.1
Checking keyed_priority_queue v0.4.2
Checking combine v4.6.8
Checking streaming-stats v0.2.3
Checking cargo-platform v0.3.3
Checking semver v1.0.28
Compiling pin-project-internal v1.1.13
Checking bstr v1.13.1
Checking jiff-core v0.1.1
Checking fallible-iterator v0.3.0
Checking array-init v2.1.0
Checking take-until v0.2.0
Checking bitstream-io v2.6.0
Checking atomic_refcell v0.1.14
Checking arraydeque v0.5.1
Checking matchit v0.8.4
Checking h264-reader v0.8.0
Checking srt-protocol v0.4.4
Checking axum v0.8.9
Checking sdp-types v0.1.8
Checking jiff v0.2.37
Checking pin-project v1.1.13
Checking cargo_metadata v0.23.1
Checking str0m v0.24.1
Checking egui-wgpu v0.36.2
Checking stun-types v2.0.3
Checking egui-winit v0.36.2
Compiling uniffi_macros v0.32.2
Compiling moq-c v0.7.0 (/work/rs/moq-c)
Compiling moq-gst v0.4.12 (/work/rs/moq-gst)
Compiling duplicate v2.0.1
Checking http-auth v0.1.10
Checking tokio-stream v0.1.19
Checking uniffi_core v0.32.2
Checking pretty-hex v0.4.2
Checking egui_dock v0.21.1
Checking uniffi v0.32.2
Checking srt-tokio v0.4.4
Checking retina v0.4.21
Checking moq-ice v0.1.0 (/work/rs/moq-ice)
Checking eframe v0.36.2
Checking m3u8-rs v6.0.1
Compiling moq-vaapi v0.1.0
Checking moq-json v0.5.8 (/work/rs/moq-json)
Checking moq-loc v0.2.19 (/work/rs/moq-loc)
Checking qmux v0.7.0 (/work/rs/qmux)
Checking gstreamer-base v0.25.4
Checking gstreamer-audio v0.25.4
Checking hang v0.21.11 (/work/rs/hang)
Documenting hang v0.21.11 (/work/rs/hang)
Checking moq-tokio v0.19.23 (/work/rs/moq-tokio)
Checking moq-mux v0.10.11 (/work/rs/moq-mux)
Documenting moq-mux v0.10.11 (/work/rs/moq-mux)
error: recipe `lint-changed` failed on line 70 with exit code 143
ci: check py failed
ci: seconds per module
40 check py (failed)
40 check rs (cancelled)
40 check c (cancelled)
41 wall time
error: recipe `ci` failed on line 107 with exit code 1
. |
|
codex / Codex land fixer: (written by codex / Codex) |
|
quest land removed this pull request from the queue: Conflicts with the base: flake.lock, flake.nix |
|
codex / Codex land fixer: (written by codex / Codex) |
# Conflicts: # flake.lock # flake.nix
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
- Merged
origin/mainand resolved thequestpin conflict — main's #7427 had independently bumpedquest1ef2ca7→b1f0c40; the merge kept this branch's7a191e6.
The merge changed no PR content of its own (git diff f9b2e65 51d24c2 on flake.nix/flake.lock is empty). I confirmed 7a191e6 is 22 commits ahead of main's b1f0c40 (compare/b1f0c40...7a191e6 is ahead with behind_by: 0), so the resolution supersedes main's concurrent bump rather than reverting it. flake.nix and both flake.lock revs stay on 7a191e6 with matching narHash/lastModified.
deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏
|
quest land removed this pull request from the queue: the batch check failed (exit 100). PASS [ 0.471s] (9287/9337) moq-video frame::cuda::tests::auto_external_captures_are_distinguishable
PASS [ 0.095s] (9288/9337) moq-uring::integration endpoint::dropping_the_last_connection_handle_closes_it
PASS [ 0.103s] (9289/9337) moq-uring::integration endpoint::dropping_the_last_raw_session_closes_the_connection
PASS [ 21.600s] (9290/9337) moq-net model::group::test::a_long_compressed_group_sheds_its_front
PASS [ 3.139s] (9291/9337) moq-tokio::integration reconnect::two_peers_redirecting_to_each_other_escalate_the_backoff
PASS [ 2.158s] (9292/9337) moq-video encode::encoder::tests::transcode_keeps_the_space_the_source_signalled
PASS [ 3.065s] (9293/9337) qmux session::tests::websocket_keep_alive_runs_during_continuous_output
PASS [ 3.101s] (9294/9337) moq-uring::integration endpoint::cancelling_a_dial_releases_its_connection
PASS [ 0.291s] (9295/9337) moq-uring::integration endpoint::unsupported_version_is_negotiated_only_by_servers
PASS [ 0.088s] (9296/9337) moq-uring::integration identity::a_stopped_worker_fails_dials_and_accepts
PASS [ 0.057s] (9297/9337) moq-uring::integration identity::an_endpoint_refuses_a_stopped_worker
PASS [ 0.693s] (9298/9337) moq-uring::integration identity::an_endpoint_runs_on_the_worker_that_adopted_its_socket
PASS [ 0.109s] (9299/9337) moq-uring::integration local_addr::a_dual_stack_wildcard_answers_a_v4_peer_from_the_address_reached
PASS [ 0.109s] (9300/9337) moq-uring::integration local_addr::a_v4_wildcard_answers_from_the_address_reached
PASS [ 0.094s] (9301/9337) moq-uring::integration local_addr::a_wildcard_endpoint_handshakes_on_a_secondary_address
PASS [ 0.153s] (9302/9337) moq-uring::integration mtu::a_path_at_the_ipv6_minimum_connects
PASS [ 0.359s] (9303/9337) moq-uring::integration mtu::a_shrinking_path_falls_back_to_the_floor
PASS [ 0.125s] (9304/9337) moq-uring::integration mtu::discovery_finds_a_larger_mtu
PASS [ 0.151s] (9305/9337) moq-uring::integration mtu::discovery_stays_off_by_default
PASS [ 0.116s] (9306/9337) moq-uring::integration receive_credit::partial_frame_gives_way
PASS [ 0.091s] (9307/9337) moq-uring::integration session::a_root_bundle_is_loaded_whole
PASS [ 0.091s] (9308/9337) moq-uring::integration session::configured_roots_verify_the_server
PASS [ 0.101s] (9309/9337) moq-uring::integration session::lite_session_over_the_worker
PASS [ 0.092s] (9310/9337) moq-uring::integration session::required_client_auth_refuses_an_anonymous_client
PASS [ 0.110s] (9311/9337) moq-uring::integration session::two_lite_sessions_share_the_server_socket
PASS [ 0.092s] (9312/9337) moq-uring::integration teardown::a_published_close_has_already_left_the_client
PASS [ 0.058s] (9313/9337) moq-uring::integration teardown::a_send_staged_on_the_way_out_still_goes
PASS [ 0.093s] (9314/9337) moq-uring::integration teardown::handles_outliving_the_worker_fail
PASS [ 0.007s] (9315/9337) moq-uring::integration transport::adapter::outcome_tests::typed_ring_close_kinds_survive_the_adapter
PASS [ 0.006s] (9316/9337) moq-uring::integration transport::adapter::tests::forwards_thread_local_streams_and_keeps_error_codes
PASS [ 0.006s] (9317/9337) moq-uring::integration transport::adapter::tests::preserves_session_close_codes
PASS [ 0.094s] (9318/9337) moq-uring::integration web::a_clean_finish_closes_a_stream
PASS [ 0.093s] (9319/9337) moq-uring::integration web::a_dropped_session_delivers_its_close
PASS [ 0.094s] (9320/9337) moq-uring::integration web::a_dropped_stream_carries_a_webtransport_code
PASS [ 1.092s] (9321/9337) moq-uring::integration web::a_rejection_reaches_the_peer
PASS [ 0.094s] (9322/9337) moq-uring::integration web::a_reset_stream_keeps_its_header
PASS [ 0.093s] (9323/9337) moq-uring::integration web::a_reset_stream_keeps_its_header_without_credit
PASS [ 8.283s] (9324/9337) moq-video encode::producer::tests::clock::hls_records_keep_the_live_timestamps
PASS [ 0.092s] (9325/9337) moq-uring::integration web::an_abandoned_handshake_closes_the_connection
PASS [ 0.093s] (9326/9337) moq-uring::integration web::an_unpolled_handshake_closes_the_connection
PASS [ 0.094s] (9327/9337) moq-uring::integration web::cancelling_before_peer_settings_closes_the_connection
PASS [ 0.105s] (9328/9337) moq-uring::integration web::cancelling_while_awaiting_connect_closes_the_connection
PASS [ 0.103s] (9329/9337) moq-uring::integration web::lite_session_over_webtransport
PASS [ 0.096s] (9330/9337) moq-uring::integration web::the_last_web_session_drop_delivers_a_close_capsule
PASS [ 0.119s] (9331/9337) moq-uring::integration web::webtransport_accepts_a_buffered_uni_after_the_peer_close
PASS [ 0.098s] (9332/9337) moq-uring::integration web::webtransport_echo_end_to_end
PASS [ 0.263s] (9333/9337) moq-uring::integration workers::a_steered_group_serves_a_shared_port
PASS [ 10.100s] (9334/9337) moq-uring::integration endpoint::an_unanswered_dial_times_out
PASS [ 10.091s] (9335/9337) moq-uring::integration endpoint::the_backlog_bounds_pending_handshakes
PASS [ 10.099s] (9336/9337) moq-uring::integration endpoint::the_backlog_bounds_queued_connections
SLOW [> 60.000s] (─────────) moq-net ietf::publisher::serve_tests::a_cold_reported_copy_serves_its_first_wire_object
TERMINATING [>120.000s] (─────────) moq-net ietf::publisher::serve_tests::a_cold_reported_copy_serves_its_first_wire_object
TIMEOUT [ 120.005s] (9337/9337) moq-net ietf::publisher::serve_tests::a_cold_reported_copy_serves_its_first_wire_object
stdout ───
running 1 test
test ietf::publisher::serve_tests::a_cold_reported_copy_serves_its_first_wire_object has been running for over 60 seconds
(test timed out)
Cancelling due to test failure:
────────────
Summary [ 137.019s] 9337 tests run: 9336 passed, 1 timed out, 108 skipped
TIMEOUT [ 120.005s] (9337/9337) moq-net ietf::publisher::serve_tests::a_cold_reported_copy_serves_its_first_wire_object
stdout ───
running 1 test
test ietf::publisher::serve_tests::a_cold_reported_copy_serves_its_first_wire_object has been running for over 60 seconds
(test timed out)
error: test run failed
mbx[cache]: object cache: 24 hits, 76 misses, 2 bypassed; 0 B downloaded, 0 B uploaded, 7.4 GiB stored locally
mbx[cache]: 7m 45s session; 38.24s estimated compiler time avoided (summed across compilations)
mbx[cache]: bypass reasons: 2 unsupported-crate-type
mbx[cache]: Cargo artifact reuse and CI cache archive transfers are not included above
mbx[savings]: 4.5 TiB logical of target/ was waiting for checkouts that are never coming back. it has stopped waiting.
error: recipe `test` failed on line 274 with exit code 100
error: recipe `test-changed` failed on line 82 with exit code 100
ci: test rs failed
ci: seconds per module
79 check rs
466 test rs (failed)
215 check obs_compile
364 check js
85 test js
12 check markdown
7 check gh
44 test gh
121 check flake
2 check drill
3 check quest
20 check obs
16 check shell
0 check large_files
1 check toml
1 check nix
0 check justfile
546 wall time
error: recipe `ci` failed on line 107 with exit code 100
. |
|
codex / Codex land fixer: (written by codex / Codex) |
Summary
Pins the dev shell's
questat moq-dev/quest@7a191e6, the revision the host land gate already runs. The old pin (1ef2ca7, 2026-10-30) predates moq-dev/quest#306. With it, aquest merge --landre-pick after a push asked GitHub to enable auto-merge again; GitHub kept the existing request and its staleQuest-Land-Head, and the land gate then ejected the PR ashead_moved(seen on moq-dev/moq#6985). Since #306, a re-pick disables and re-enables auto-merge, so the pin names the new head.Checks
CHECK_FAIL_FAST=1 just ci origin/mainpasses;nix developbuilds and runs the newquest.Review
Skipped as trivial: a pinned-revision bump of a dev-shell tool, matching the gate's own pin.
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)