Repository navigation
quest: plan pinning a quest that re-pins a queued PR #7580
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # [XS] Pin a quest that re-pins a queued PR | ||
|
|
||
| ## Goal | ||
|
|
||
| moq's dev shell runs a moq-dev/quest whose `quest merge <pr> <token> --land | ||
| <sha>` moves an already-queued PR's `Quest-Land-Head` pin to the new head. | ||
| Merge sessions that run from this shell then never leave a stale queue entry | ||
| for the gate to reject. Check it by re-pinning a queued PR and reading its | ||
| auto-merge commit body. | ||
|
|
||
| ## Plan | ||
|
|
||
| Decided 2026-11-01 (user, /quest-plan of the follow-ups from a moq-dev/quest | ||
| /quest-complete session): | ||
|
|
||
| - ✅ Plan the bump as its own quest: a pin bump that unblocks work is its own | ||
| quest. | ||
| - The pinned quest (`7a191e6`, reporting 0.1.0) left | ||
| [moq-dev/quest#290](https://github.com/moq-dev/quest/pull/290) and | ||
| [moq-dev/quest#319](https://github.com/moq-dev/quest/pull/319) queued on | ||
| their old heads after a push, and each needed a manual requeue. | ||
|
Comment on lines
+18
to
+21
Contributor
There was a problem hiding this comment. This premise is contradicted by the repo's own history. #7511 pinned the dev shell's Technical details# Pin bump may be a no-op
## Evidence
- `flake.nix` pins `quest` at `7a191e6197c691f477b4c55edba34cc425c3e77c`, set by moq-dev/moq#7511 (merged 2026-11-01T21:05Z). Its body: the old pin `1ef2ca7` (2026-10-30) predated #306; since #306 a re-pick "disables and re-enables auto-merge, so the pin names the new head".
- At the pinned rev, `src/cli/land.ts` `enqueue()` disables an existing auto-merge request pinned to another head and re-enables it with the new pin. `moq-dev/quest#306` is an ancestor of `7a191e6` (confirmed by compare).
- `src/cli/hold.ts` on quest `main` has no commit newer than #314 (also pre-pin), so no later re-pin fix exists there.
- Timing: #7511 landed 21:05; #290's later re-picks (21:18, 21:51) produced no `quest land` ejection comment, so the new pin appears to have worked.
## Required outcome
- Re-check the failure against the pinned CLI and either drop this quest as already fixed, or replace the rationale with the actual remaining symptom (for example, a dev shell still running the pre-#7511 binary, or a `/quest-complete` flow that re-picks with the stale head rather than the new one).
Collaborator
Author
There was a problem hiding this comment. Agreed. (Written by Claude Opus 5.5) |
||
| - Bump `inputs.quest` in `flake.nix` to a current moq-dev/quest main. A newer | ||
| quest also brings the land fixer's prompt and `quest merge --land` fixes. | ||
|
|
||
| ## Related | ||
|
|
||
| - [Cheap checks skip the queue](/quest/m0/ci/gate-quick.md) - also waits on a pin that includes `quest gate --quick` | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reformatting is unrelated to the quest. The repo excludes
quest/from its markdown check (.remarkignore), so CI does not require it, and it makes this the only padded table inquest/. The PR body describes the change as "one quest file and one link". Reverting keeps the PR to one problem.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, and it's moot now:
mainalready carries this table's padded form, so a merge would leave no diff here. See the reply onquest-pin.md: I'm recommending this PR be closed.(Written by Claude Opus 5.5)