[kixelated]

Problem

The scheduled 2026-11-03 Miri job failed before running tests because its nightly toolchain had no Rust sources.

Approach

Install miri, rust-src together and name both components in the local setup hints. Keep the Miri budget quest, narrowed to the scheduled ARM timing proof and any optimization those timings justify, with an explicit Waiting item.

Impact

• Public API: none. Wire: none. No migration.
• The 60-minute job budget, 15-minute nextest cap, all test workloads, and both Miri pass configurations are unchanged.

Validation

• quest gate nix develop --command just ci: passed on the final code, including 11,698 Rust tests passed, 133 skipped, workflow lint/security checks, and repository tooling tests.
• Fresh isolated minimal nightly 1.101.0-nightly (708c94ef0 2026-11-03), installed with miri,rust-src: Miri sysroot preparation succeeded. just rs miri -E 'test(/(growing_buffer_keeps_handed_out_slices|reads_every_entry_across_segments)$/)' passed one strict frame test and one epoch log test. These x86_64 smoke results establish setup only, not the scheduled ARM budgets.
• quest check --base origin/main: 596 documents OK. git diff --check origin/main...HEAD: passed. A read-only merge-tree check against the latest fetched main reported no conflicts.

Alternatives

No speculative workload reduction or pass split: scheduled ARM timings must justify either. Desktop smoke tests verify setup only. No timeout increase or weakened frame-cap coverage.

Review

Claude Code, Claude Opus 5.5 (claude-opus-5-5), medium effort, reviewed head 6ec0b212c20df51bee145559530d0982546a9575 against origin/main at 00a3c57dcac5efdfd6a05fe07a3b8267d95cdbc9. No findings.

The earlier review's only finding was fixed: both local setup commands and the recipe comment now require rust-src alongside Miri.

Follow-ups

The existing quest must record the next scheduled Tests (rs miri) run on ubuntu-24.04-arm, including job/pass durations, slowest test, and headroom. No Nightly dispatch or merge wait was used. Recommend landing this setup fix, then revisiting that quest after the scheduled run.

The planning PR moq-dev/moq#7748 also proposes the setup change in a new miri-frame.md quest, but implements no workflow or runner change. Reconcile that planning overlap with the existing Miri quest when it lands; this PR does not modify the planning branch. Supplied workflow overlaps and newer open PR file lists were inspected before implementation; their changes were not imported.

(Written by GPT-6.1 Sol)

[kixelated]

Automated review by review (OpenAI)

Reviewed head 6ec0b21.

No actionable findings. The Nightly Miri entry installs both required components, and the local setup hints match. The strict and epoch passes and their budgets remain unchanged; the quest appropriately keeps scheduled ARM timing confirmation open.

Verification: GitHub-only static review of the workflow, toolchain setup, runner and quest. I did not run Miri or dispatch Nightly.

(Written by review (OpenAI))

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The nightly Miri matrix entry and local Miri instructions now include rust-src alongside Miri. The quest describes the next scheduled ARM run required for timing evidence and lists the measurements to record.

Merge Risk: Minimal · up to 6ec0b

The setup fix is mergeable. Record timing and budget headroom from the next scheduled ARM run before clearing the quest.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title "fix(ci): install Rust sources for Nightly Miri" matches the main change. The raw summary shows the nightly workflow's rs miri entry now installs rust-src alongside miri, and the PR objectiv…
Description check		The description states the problem (the scheduled 2026-11-03 Miri job failed because its nightly toolchain had no Rust sources), the approach (install miri and rust-src together and name both componen…
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "fix(ci): install Rust sources for Nightly Miri" matches the main change. The raw summary shows the nightly workflow's rs miri entry now installs rust-src alongside miri, and the PR objectives state the scheduled Miri job failed because its nightly toolchain lacked Rust sources. The title is specific and concise, and it names the fix and its scope.

Full details: Description check

Explanation

The description states the problem (the scheduled 2026-11-03 Miri job failed because its nightly toolchain had no Rust sources), the approach (install miri and rust-src together and name both components in local setup hints), the impact, validation, alternatives, and follow-ups. These match the raw summary's changes to nightly.yml, miri.md, rs/justfile, and sh/rs/miri.sh. The description is detailed and related to the changeset.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (3 skipped: 3 unsupported.)

Finishing Touches

Simplify code

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 407f4984-9058-4223-ab1a-173873f9b022

Commits

Reviewing files that changed from the base of the PR and between eacff68 and 6ec0b21.

Files selected for processing: 4

• .github/workflows/nightly.yml
• quest/m0/nightly/miri.md
• rs/justfile
• sh/rs/miri.sh

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

[pullfrog]

✅ No new issues found.

Reviewed changes

• Nightly workflow: the rs miri matrix entry now installs miri, rust-src via dtolnay/rust-toolchain (.github/workflows/nightly.yml:363), so cargo miri finds the Rust sources it needs; the comma-separated syntax is split into two --component flags by the action.
• Local hints: sh/rs/miri.sh and the rs miri recipe comment now name rust-src alongside Miri, and both commands use valid rustup syntax (--component a,b for toolchain install, positional components for component add).
• Quest: quest/m0/nightly/miri.md keeps the budget quest open, gates optimization on scheduled ARM timings, and adds a Waiting item for the next scheduled ubuntu-24.04-arm run.

Budgets, pass filters, and workloads are unchanged, and the fix matches the reported failure (missing rust-src, not a test failure).

  ^{｜ View workflow run ｜ Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏}