Skip to content

moq-gst releases publish again - #8105

Merged
moq-bot[bot] merged 7 commits into
mainfrom
quest/m0/ci/gst-release-macos
Nov 7, 2026
Merged

moq-bot[bot] merged 7 commits into
mainfrom
quest/m0/ci/gst-release-macos

Conversation

@kixelated

@kixelated kixelated commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Quest: quest/m0/ci/gst-release-macos.md. Done, so this PR deletes it with quest rm (which also drops its link from quest/m0/ci/README.md).

The fix was the backport to release in moq-dev/moq#8109, merged at bbecb46. It brings over moq-dev/moq#5841's Homebrew formula test, which no longer runs gst-inspect-1.0 inside the sandbox.

Evidence

  • moq-dev/moq#8128 merged, and release-plz pushed moq-gst-v0.4.24.
  • That tag's moq-gst run 42345747713 succeeded, Build tarball (aarch64-apple-darwin) included.
  • gh release view moq-gst-v0.4.24 shows it published at 2026-11-07T06:21:25Z.

Decisions

  • Decided 2026-11-07 (maintainer, /quest-unblock): ✅ patch-bump moq-gst to 0.4.24 now (moq-dev/moq#8128). Not chosen: waiting for the next combined release; hand-pushing a tag.

Validation

  • quest check and quest check --base origin/main: 592 documents ok.

Review

mechanical fix by quest land watch: merged main at ffe9c7d17d9f1e38b2e0d30f75650ae00bf7d99b with the quest merge driver (head 166f1af)

  • Skipped as too trivial: the head only deletes a finished quest doc and its README link, with no code change.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated and others added 2 commits November 6, 2026 22:23
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review November 7, 2026 06:23
@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CI checklist no longer includes the task to backport the Homebrew formula test to release. The planning document about the macOS test failures, proposed backport, and decision not to backfill releases 0.4.21–0.4.23 was deleted.

Merge Risk: Minimal · up to 166f1

This documentation-only cleanup removes the completed macOS release follow-up. No actionable merge-blocking risk is identified.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title describes the restored releases associated with the completed quest.
Description check Passed The description accurately identifies the quest document and README link removed by the PR.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches

Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d7ea4fa1-b65c-424a-ac75-0a39d999a461
Commits

Reviewing files that changed from the base of the PR and between ffe9c7d and 166f1af.

Files selected for processing: 2

  • quest/m0/ci/README.md
  • quest/m0/ci/gst-release-macos.md
Files with no reviewable changes: 1

  • quest/m0/ci/gst-release-macos.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@pullfrog pullfrog Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Quest doc deleted — quest/m0/ci/gst-release-macos.md (44 lines) is removed now that moq-gst-v0.4.24 is published.
  • README entry dropped — the matching bullet is gone from ## Required in quest/m0/ci/README.md, as quest rm produces.

I confirmed the deletion is safe and justified: no file in the tree references the removed path or quest title, Quest passed on this head (run 42346802114), and the outcome it tracked is real — moq-gst-v0.4.24 is a published non-draft release, backport #8109 merged at bbecb46a5, and bump #8128 merged. The rationale the doc carried (the Homebrew sandbox hanging gst-inspect-1.0) is already durable in the comment at .github/homebrew/Formula/moq-gst.rb.tmpl:46.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: ee0b776
Base: 3eb044f

No actionable findings. Removing the completed quest and its index entry is supported by the GitHub evidence: #8109 is merged into release at bbecb46; run 42345747713 succeeded, including Build tarball (aarch64-apple-darwin) and Release; and moq-gst-v0.4.24 is a published non-draft release dated 2026-11-07T06:21:25Z. Those outcomes match the deleted quest's goal.

Direction: this closes the tracked release failure without introducing another code or release-process change.

Verification: GitHub-only review of both changed documents, the merged backport metadata, workflow/job conclusions and release metadata. I did not rerun builds or quest validation, install the release, or independently exercise the Homebrew sandbox. This is a COMMENT, not approval.

(Written by review (OpenAI))

@kixelated
kixelated added this pull request to the merge queue Nov 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 7, 2026
@moq-bot

moq-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

quest land watch: the merge queue removed this pull request at ee0b776 because it conflicts with main (merge_conflict).

The land fixer works on it in the background, and the watcher re-enqueues it at the back of the queue once it is fixed or judged flaky, or hands it back here with what it needs.

(written by quest land watch)

@moq-bot
moq-bot Bot enabled auto-merge November 7, 2026 10:24
@moq-bot

moq-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

quest land watch: armed auto-merge on this pull request at 166f1af, so it joins the back of the merge queue once its required checks pass, with main at ffe9c7d merged in by the quest merge driver.

(written by quest land watch)

@moq-bot
moq-bot Bot added this pull request to the merge queue Nov 7, 2026
Merged via the queue into main with commit 81a5dc6 Nov 7, 2026
9 of 10 checks passed
@moq-bot
moq-bot Bot deleted the quest/m0/ci/gst-release-macos branch November 7, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant