Skip to content

feat(skills): plan reviews before ready; merge and review reuse a counted record #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moq-bot merged 4 commits into from
Nov 1, 2026
Merged

feat(skills): plan reviews before ready; merge and review reuse a counted record #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
755ded4
feat(skills): plan reviews before ready; merge and review reuse a rec…
kixelated Oct 30, 2026
025224d
fix(skills): reuse only a review record the guide counts
kixelated Oct 30, 2026
58163ec
Merge origin/main into skills/review-record-gaps
kixelated Nov 1, 2026
e10299a
quest land: merge tested base
Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions assets/skills/plan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,5 @@ Once complete, create, update, or delete the relevant quests and epics.
Record each settled decision and its reason in the quest's Plan, so later sessions don't ask it again, and the decision prompts in the PR.
New work joins the milestone the user picked, at its rank; an epic groups related quests, and its README holds the work no child owns (the end-to-end test, the docs page).

When done, commit, open the PR ready for review, and run `/quest-merge` on it.
Quests planned as follow-ups of an open PR may be committed to that PR instead.
The quest should be reviewed before it is merged.
When done, commit, open the PR as a draft, and run `/quest-review` on it, which reviews the branch, records the `## Review` section, and marks the PR ready.
Quests planned as follow-ups of an open PR may be committed to that PR instead, whose next push is reviewed as the guide's Reviews section describes.
3 changes: 2 additions & 1 deletion assets/skills/review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ A draft you started in this session has no `## Decisions needed` section, so it
Work in a checkout of the PR's head branch, checking out the head first when someone else opened it.
Commit everything, then run the repository's local checks, unless the guide's Reviews section says to run no code from the head, and fix any failure.

Review the committed branch with `quest review`, as the guide's Reviews section describes; `quest review --help` explains the round.
If a `## Review` record the guide counts names the committed head, or the guide's review exemptions cover the changes since the head it names, and it leaves no finding unrefuted, run no new round and go on to pushing and marking it ready below.
Otherwise, review the committed branch with `quest review`, as the guide's Reviews section describes; `quest review --help` explains the round.
Run it in the foreground; a round takes minutes.
Fix each finding you agree with, or refute it with evidence the reviewer can check.
Commit the fixes, rerun the checks, and run the next round with `--responses`, one response per finding, written in the checkout's `.tmp/`.
Expand Down
Loading