Repository navigation
fix(agent): don't pass a land check's base to launched agents - #307
Merged
Merged
Conversation
#304 gives land checks QUEST_LAND_BASE, and quest agent forwarded it, so every quest batch failed its own agent tests. Like QUEST_GATE_ADMITTED, it describes the caller's gate, not the agent's work. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 21 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every quest batch now fails in the host gate. #304 gives land checks
QUEST_LAND_BASE, andquest agentforwarded it to the agents it launches, sotest/agent.test.ts's exact-environment assertions failed. This ejected #306, for example.QUEST_LAND_BASEnow joinsquest agent's stripped variables besideQUEST_GATE_ADMITTED: it describes the caller's gate, not the agent's work. The stripping test covers it.Checks
just checkandjust testpass, withQUEST_LAND_BASEset as the gate sets it (705 CLI and 426 Worker tests).Review
quest review --base origin/main, round 1🤖 Generated with Claude Code
(written by Claude Opus 5.5)