Repository navigation
fix(land): wait for GitHub to show the fixer's push - #311
Merged
Merged
Conversation
After pushing a fix, the daemon reread the PR to record it, but GitHub still showed the old head, so it handed back a PR it had just fixed (#309 in the live canary). It now waits up to a minute for its own head; only a third head is a real move. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the live canary. The fixer correctly fixed #309: it merged the base, followed #308's rename, and verified the result. The daemon validated those commits and pushed them as moq-bot (
b380388). It then reread the PR to write the## Reviewline, but GitHub still showed the old head, so it raised "head moved before Review update" and handed back a PR it had just fixed.The daemon now waits up to a minute for GitHub to show the head it pushed. It treats only a third head as a real move.
Checks
just checkandtest/land.test.tspass (114).Review
quest review --base origin/main, round 1🤖 Generated with Claude Code
(written by Claude Opus 5.5)