Repository navigation
fix(land): keep git maintenance from racing the fixer import - #360
Merged
Merged
Conversation
A fixer job crashed with ENOENT on a vanished objects/maintenance.lock (moq-dev/moq#6987): background maintenance removed the lock between importFixer's readdir and lstat. Fixer checkouts now turn off gc.auto and maintenance.auto, and the import skips git lock files, which it never imports. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
kixelated
enabled auto-merge (squash)
November 1, 2026 16:47
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A land fixer job for moq-dev/moq#6987 crashed with
[Errno 2] No such file or directory: '.../fix-qrkoPz/.git/objects/maintenance.lock'. Background git maintenance in the fixer checkout removed its lock file betweenimportFixer'sreaddirSyncandlstatSync, and the crash handed the PR back. Two changes:startFixer(src/cli/land-fixer.ts) setsgc.auto=0andmaintenance.auto=falsein each fixer checkout, so nothing repacks or deletes objects while the daemon imports the result.importFixer(src/cli/land-fixer-repository.ts) skips git*.lockentries before reading them, since it never imports a lock file.Checks
just checkpasses, and so doestest/land.test.ts(130 tests)..locksymlink underobjects/. It fails without the fix ("fixer git metadata must contain only real files and directories") and passes with it.Review
quest review(Codex, gpt-6.1-sol, medium effort) againstorigin/mainat head7f6408c397e21c8e9dd6c461a19a71e09e8bdf96: round 1, 0 findings.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)