Skip to content

chore(quest): plan the 2026-10-27 follow-ups and split the exporter into an epic - #142

Merged
kixelated merged 1 commit into
mainfrom
plan/followups-1027
Oct 28, 2026
Merged

kixelated merged 1 commit into
mainfrom
plan/followups-1027

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

The PRs merged on 2026-10-27 (#110, #115, #118, #124, #126, #127, #128, #129, #130) reported follow-ups that had no quest, including a silent miscompile on main. quest/m1/ffi-export.md was one XL quest that said "split into quests as work starts", and its Paths item became startable when moq-dev/moq#6843 merged.

Approach

  • m2, ranked first:
    • ts-swap-parts: (a, b) = (b, a) on two &[u8] translates to a = b; b = a, through var_parts in place.rs.
    • ts-harness-names: the lang fixture's hand-numbered op % N collided in every concurrent ts PR.
  • m2 ts-model:
  • ts-drop.md: rt.iterFromFn and rt.iterSuccessors get droppers.
  • ts-model README: moq writes the binding files that model.toml names.
  • m3: ts-fold-guards, ts-partial-ord, ts-range-fold, ts-bool-core, ts-bind-gaps.
  • m1 ffi-export/ becomes an epic. Its children: paths, instance-keys, lent-closures, crates, driving, contract, cpp, kotlin. The README keeps the end-to-end work and the rules every generator meets, async included.

Decisions

  • Swap bug: ✅ [S] m2, ranked first / fold into byte-views / fix now, no quest
  • ffi follow-ups: ✅ ffi-export becomes an epic / flat m1 quests / four separate quests
  • ffi epic split: ✅ every item a child / new children + paths only / flat m1 quests
  • ffi order: ✅ census first (paths, instance-keys, lent-closures, crates, driving, contract, then generators) / generators first
  • ffi async: ✅ fold into each generator / async child after both / standalone async child
  • ts std follow-ups: ✅ two ts-model children / one ts-model child / m3
  • Harness dispatch: ✅ [S] m2 after the swap bug / m3
  • Smaller follow-ups: ✅ "whatever you recommend", so all four: harness, iterator droppers into ts-drop, each m3 gap as its own quest, binding gaps
  • Integer methods from core's MIR: ✅ skip (core-mir decided they stay in the runtime) / plan in m3

Impact

  • No public API change.

Alternatives

  • Make ffi-export an epic with only the new children: its README's other items would then wait on them.

Follow-ups

  • land.md predates kixelated/quest's switch from GitHub Actions to an App as the push bypass, and needs replanning.

(written by Opus 5.5)

🤖 Generated with Claude Code

https://claude.ai/code/session_01HRfpGSuhrqBv8bAxEvpXi3

…nto an epic

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HRfpGSuhrqBv8bAxEvpXi3
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T02:07:33.835395Z dc1d7c5 PR opened
🔒 Security Review ✅ Completed 2026-10-28T02:08:24.559293Z dc1d7c5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: dc1d7c5

No actionable bugs found in this planning-only change. Prioritizing the slice-swap miscompile and replacing hand-numbered harness dispatch is sensible. The exporter split makes the work more tractable while retaining shared cancellation/wake, ABI-contract, and performance requirements; rerunning the census before implementing gaps avoids unnecessary machinery. The recorded bugs remain follow-up work, not fixes delivered by this PR.

Verification limits: static review of the changed plans and selected surrounding source/merged-PR context only. No builds, tests, census, or benchmarks were run, and the listed runtime bugs were not independently reproduced.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: plan-only. Both automated reviews of dc1d7c5 are clean, just check and quest check --base origin/main pass, and the head contains main. Decisions are recorded in the PR body. Landing as a squash.

(written by Opus 5.5)

@kixelated
kixelated merged commit 9941b5b into main Oct 28, 2026
1 check passed
@kixelated
kixelated deleted the plan/followups-1027 branch October 28, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant