Repository navigation
chore(quest): plan for stock crates that translate without config - #143
Conversation
A stock crate should translate with no annotations or config. Record that in AGENTS.md, move `unsafe` and trait objects from never to not yet, and plan the gaps: well-known crates mapped by rust2-ts itself (m2) and trait objects (m3). moq's safe cfg twins stay as a stopgap that ts-unsafe retires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 799017c
No actionable bugs found in this planning-only change. Moving consumer-specific bindings and source rewrites toward translator-owned support is a coherent direction; retaining explicit platform boundaries and refusing unsafe operations outside the modeled set avoids turning zero configuration into silent semantic changes. The small stock-crate mapping milestone is a sensible bridge to source translation, while trait objects correctly retain dispatch, drop, lazy-future, and cancellation requirements.
This records future work, not delivered unsafe/trait-object support. Verification: static inspection of the changed plans and related async/unsafe plans and model configuration only; I did not run quest check, builds, tests, or a model census.
|
Merging at 799017c. Codex code and security reviews of this head finished with no findings. (Written by Claude Opus 5.5) |
Problem
rust2-ts needs consumer config and source changes to translate moq's model: a
[bind]table,ignore-macros, safecfg(rust2_ts)twins, anddyn Expiryrewritten as an enum. The README's "Never" list madeunsafeand trait objects permanent reasons to bind.Decisions
Decided with the maintainer on 2026-10-27: a stock Rust crate should translate with no annotations or config.
AGENTS.md, covering ts and ffi ·ts/READMEdesign goals · ts-model epic plan.AGENTS.mdwording: ✅ as written · scoped to rust2-ts.unsafeand trait objects move to "Not yet" · keep "Never".cfgtwins: ✅ stay as a stopgap, with ts-unsafe in m3 retiring them · move ts-unsafe to m2.dependencieskey: ✅ inferred in feat(ts): translate every non-std dependency the roots reach with the package #141 · kept with a follow-up. That change lands in feat(ts): translate every non-std dependency the roots reach with the package #141.Changes
AGENTS.md: one Guidelines line.ts/README.md: the "Never" section folds into "Not yet", linking the quests.Checks:
quest checkpasses. Only markdown changed.Public API: none.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code