Skip to content

chore(quest): plan for stock crates that translate without config - #143

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/zero-config
Oct 28, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/zero-config

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

rust2-ts needs consumer config and source changes to translate moq's model: a [bind] table, ignore-macros, safe cfg(rust2_ts) twins, and dyn Expiry rewritten as an enum. The README's "Never" list made unsafe and trait objects permanent reasons to bind.

Decisions

Decided with the maintainer on 2026-10-27: a stock Rust crate should translate with no annotations or config.

Changes

Checks: quest check passes. Only markdown changed.

Public API: none.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

A stock crate should translate with no annotations or config. Record
that in AGENTS.md, move `unsafe` and trait objects from never to not
yet, and plan the gaps: well-known crates mapped by rust2-ts itself
(m2) and trait objects (m3). moq's safe cfg twins stay as a stopgap
that ts-unsafe retires.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T02:19:04.734561Z 799017c PR opened
🔒 Security Review ✅ Completed 2026-10-28T02:19:50.700044Z 799017c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)
Reviewed commit: 799017c

No actionable bugs found in this planning-only change. Moving consumer-specific bindings and source rewrites toward translator-owned support is a coherent direction; retaining explicit platform boundaries and refusing unsafe operations outside the modeled set avoids turning zero configuration into silent semantic changes. The small stock-crate mapping milestone is a sensible bridge to source translation, while trait objects correctly retain dispatch, drop, lazy-future, and cancellation requirements.

This records future work, not delivered unsafe/trait-object support. Verification: static inspection of the changed plans and related async/unsafe plans and model configuration only; I did not run quest check, builds, tests, or a model census.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging at 799017c. Codex code and security reviews of this head finished with no findings. quest check --base origin/main passes on the head. The optional Check job was still queued, and the only part of it a markdown-only diff can affect is that quest lint. No changes were made during merge. The decisions are the ones recorded in the PR body.

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit f098891 into main Oct 28, 2026
1 check passed
@kixelated
kixelated deleted the quest-plan/zero-config branch October 28, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant