Skip to content

chore(quest): plan the translator fixes the moq pin bump needs, and sessions over the C ABI - #154

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/sessions-pin
Oct 28, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/sessions-pin

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

  • #144 bumps the shared moq pin past moq-dev/moq#6843. rust2-ts then fails on std::str::from_utf8 (just ts moq) and panics in vec_view (just ts census). The vec_view mix-up also miscompiles a Vec<Foo<u8>> as bytes on any pin.
  • #150 lets C poll moq's origin Driver, but a session's Driver comes only from Client::connect/Server::accept, which need a transport C can't supply.

Decisions

Decided with the maintainer on 2026-10-27:

  • feat(ffi): export moq's owned Path #144's pin: ✅ fix the translator in separate quests first, keeping one shared pin · give ffi its own pin · fix both in feat(ffi): export moq's owned Path #144.
  • Sessions: ✅ plan a quest · skip.
  • Transport: ✅ both moq-tokio inside (the easy option most want) and moq-quic sans-IO (full control) · only moq-quic · only a callback transport.
  • Order: ✅ moq-tokio first · moq-quic first · in parallel.

Changes

Checks: quest check passes. Only markdown changed.

Public API: none.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

…essions over the C ABI

#144's pin bump breaks rust2-ts on str::from_utf8 and a vec_view
miscompile, so each gets an m1 quest. #150 found sessions need a
transport C can't supply: bindings get moq-tokio inside first, then
sans-IO QUIC.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T03:14:20.669012Z 753c865 PR opened
🔒 Security Review ✅ Completed 2026-10-28T03:15:18.429419Z 753c865 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 753c865

No actionable bugs found in this planning-only change. The direction is coherent: fix and differentially test the translator before moving the shared moq pin; deliver the runtime-managed session path before the more demanding sans-IO path. Keeping transport adapters and genuinely new runtime wrappers in moq's public API avoids application-specific exporter machinery.

The Vec-view plan matches the existing mismatch between the element type passed by as_slice/as_mut_slice and the Vec type expected by vec_view. These quests describe future fixes and C integration proofs; this PR does not implement or validate them.

Verification: inspected all six changed Markdown files, surrounding exporter/driver plans and the relevant Vec lowering. I did not run quest check, builds, differential tests or transport integration tests.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merging: Codex reviewed 753c865 with no findings (code and security). quest check --base origin/main passes on the head (52 documents ok). Planning-only change: two m1 translator quests (ts-vec-view, ts-utf8) ranked above the exporter, and two ffi-export session quests (moq-tokio first, then sans-IO QUIC), per the maintainer's decisions in the body.

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit 336eeb6 into main Oct 28, 2026
1 check passed
@kixelated
kixelated deleted the quest-plan/sessions-pin branch October 28, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant