Skip to content

chore(quest): plan the 2026-10-28 follow-ups - #195

Merged
kixelated merged 2 commits into
mainfrom
quest-plan/follow-ups-2026-10-28
Oct 28, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest-plan/follow-ups-2026-10-28

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

Follow-ups from #141 to #188 were scattered across PR bodies and reviews with no quest owning them.

Approach

Quest files only. Each item was checked against main (3b2230b) and open PRs; covered or fixed items were dropped or folded in.

New quests

  • m1, exporter epic:
    • payload-bytes [S]: impl Into<Bytes> resolves to String, so a non-UTF-8 payload aborts from C, C++, and Kotlin. Ranked first because it is a correctness bug.
    • inference-gate [XS]: CI fails on instance not inferred (refactor(ffi): infer instances in one pass before typing #188).
    • recursion-lint [S]: recursion_depth_exceeding_limit on just ffi moq.
    • kotlin-android [M]: R8 keep rule and an emulator run. This is a sibling of kotlin.md because it lands on its own.
  • m2:
    • ts-aliases [M]: stable_path nested indexes, alias()'s copy arm, and loop variables. All three are one shape: a held value names a variable that is reassigned.
    • ts-std-build [S]: try the prebuilt std now that panics abort.
  • m2, ts-model:
    • places [M]: get_or_insert_default through a &mut, and mem::take of a captured &mut Vec.
    • kio-std [S]: array::from_fn, Default of arrays and (), and maps of Option.
    • bytes [M]: BytesMut, Buf, and BufMut.
  • m3:

Folded into existing quests

  • ts-range-fold, now [M]: r.by_ref() on a RangeInclusive mistypes.
  • ts-async: poll_future::<()> does not normalize.

Dropped

Impact

None. Only quest files changed.

Alternatives

  • Fold the kio std gaps into std-rest. Rejected: its capacity work is a hot-path change of its own.

Follow-ups

None.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T22:40:53.947359Z aa9a460 PR opened
🔒 Security Review ✅ Completed 2026-10-28T22:41:48.439571Z aa9a460 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: aa9a460.

No actionable bugs found in this quest-only change. The direction is sound: group aliasing failures by their shared cause, preserve differential tests as the acceptance criterion, and measure the prebuilt-std simplification before removing -Zbuild-std. Keeping Android validation separate from the Kotlin hot-path work also gives each a clear completion boundary; instance-specific rename remains appropriately deferred until simpler naming rules are insufficient.

Verification: static review of the complete diff, related Kotlin/std quests, exporter candidate-selection and inference-refusal code, the model binding config, and referenced #173/#188 context. I did not run tests or reproduce every historical census/runtime failure; these are plans, not verified fixes.

@kixelated
kixelated merged commit 34c6b1e into main Oct 28, 2026
1 check passed
@kixelated
kixelated deleted the quest-plan/follow-ups-2026-10-28 branch October 28, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant