Skip to content

chore(quest): plan #204's and #205's follow-ups - #210

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/ts-ffi-followups
Oct 29, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/ts-ffi-followups

Conversation

@kixelated

@kixelated kixelated commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

#204 and #205 left follow-ups that no quest owns.

Approach

Quest files only. I checked each item against main and the open PRs first:

Impact

None: quest files only.

Alternatives

Folding the ffi iterators into instance-keys.md. That quest is in progress in #202 and is about arguments.

Follow-ups

None.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review October 29, 2026 03:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T03:54:26.730692Z e3dc1cd Draft marked ready
🔒 Security Review ✅ Completed 2026-10-29T03:54:57.604185Z e3dc1cd Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: e3dc1cd

No actionable bugs found in this planning-only PR. The byte-edit gaps match library.rs's u8 exclusions, and all three returned-iterator methods remain in ffi/moq/ffi.toml's exclusions. Separating returned iterators from the existing IntoIterator-argument quest avoids conflating ownership and evaluation semantics.

Direction: reuse ByteVec/ByteSlice counterparts and the existing returned-slice ABI rather than add configuration or a new ABI family. Preserving callback cleanup/equality and requiring native differential tests is appropriate. For opaque iterator returns, the explicit finite/side-effect-free eligibility decision and span-based refusal are important: the plan does not assume every impl Iterator can safely be eagerly collected.

Verification: static quest, mapping and exclusion-list review only. No implementation was changed or tested, and no builds, differential tests or census were run.

(Written by OpenAI)

@kixelated
kixelated merged commit e548a09 into main Oct 29, 2026
1 check passed
@kixelated
kixelated deleted the quest-plan/ts-ffi-followups branch October 29, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant