Repository navigation
quest: plan the overnight follow-ups - #29
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
…nchmark Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
Collaborator
Author
|
Merging. Summary:
(written by Opus 5.5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The overnight PRs (#13, #15, #16, #18, #26, #27, #28) left follow-ups and decisions, which the maintainer settled on 2026-10-24 (prompts below). They need to be quests.
Approach
New quests, each ranked in its milestone:
!where a value goes #28.just ts bench.moq-pure-cryptocorpus.-Z public-api-hashon a scratch toolchain and replay moq-net's real edits through it, counting unchanged hashes, span-only breaks, andasync fnbreaks, with incremental on and off, plus an rmeta determinism check. The report picks: carry #156940, help upstream, or stop. Relink without rebuilding notes it may change its plan.Build-speed research behind them (2026-10-24): rustc's SVH covers every body, so a reused dependent fails with E0460, and no build tool gets early cutoff for Rust today. A hash-patching wrapper is dropped: tinymold ran that spike (tinyhumansai/tinymold#13, ADR 0007) and hit E0460, and mbx rejected it as unsound (jdx/mr-boxington#645). mbx's numbers put dependents at about 1.1 s of a 1.7 s edit with incremental on, so the spike measures what incremental leaves and classifies edits by mbx's list of interface-relevant bodies. headstart (early interface-only metadata for clean builds) is not chosen for now; it also found rmeta def-id order unstable across incremental sessions, hence the determinism check. The OpenAI-funded cg_clif performance goal speeds up the backend, 6% of moq's edit, so it is not relevant. ra-jit hot-patches changed functions through Cranelift into the linked binary, claiming 12-24x, but treats
async fnbodies as signatures.Output goals, recorded in
ts/README.md's Design and the m2 Plan: correctness first, speed second, and the consumer's final tree-shaken, minified JS third; readable output is not a goal; output stays.ts; types are solid at the API boundary (root items andprintabletypes are branded), while internal casts stay since they compile away. The MIR spike now weighs its 1.4-2.6x speed ahead of its roughly 18% larger bundle. The README's opening line drops "readable".bun build --minifybundle, and caller code, with a survey of RxJS, Zod 4 mini, Valibot, Effect, date-fns, and wasm-bindgen.rtbecomes individually exported functions, kept only if no slower, with a tree-shake test.Into existing quests: Async gains
?inPoll-returning functions (about 224ready!(..)?sites in moq-net) and thetscerror on a()future awaited as a statement; Drop gains owning a temporary held across an.awaitinstead of refusing it.Merged with main after #13, #21, #26, and #30 landed. #16 is still open: it deletes
ts-async-spike.md, which these link to, and rewrites Drop and Async. Whichever merges second aligns the quests.Impact
No public API change.
ts/README.mdrecords the output goals.Alternatives
None beyond the prompts below.
Follow-ups
moq's side (the pure-crypto epic, the C name clash, the crate split rerun) is in moq-dev/moq#6659.
Decisions
?in Poll fns, ✅ Await/drop gaps, ✅!edge cases / Unusedselfparamts.tomloption(written by Opus 5.5)
🤖 Generated with Claude Code
https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn