Skip to content

chore(quest): plan integers' native-endian bytes and an exact mul_add - #300

Merged
kixelated merged 2 commits into
mainfrom
quest-plan/ne-bytes-mul-add
Oct 30, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest-plan/ne-bytes-mul-add

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

#296 left two std gaps out of its scope. Both reproduce at cecbf0d7 with spans:

  • unsupported call to core::num::<impl u32>::from_le_bytes, <impl u64>::to_ne_bytes, and <impl u64>::from_ne_bytes
  • `f64::mul_add`, which rounds once, where JS would round twice (and f32::mul_add once feat(ts): translate f32 as f64 #296 lands)

Approach

Plans two m3 quests, each with its reproduction and implementation guidance:

Both join m3 after "std accessors with no mapping", away from the f32 line #296 deletes, so the two PRs don't conflict.

Impact

  • None: quests only.

Alternatives

  • One quest per float type for mul_add: the maintainer asked for one quest covering both.

Choices made without asking

  • from_le_bytes joins the _ne_ quest because it's the same mapping gap in the same match arm.
  • quest/m3/ts-unsafe.md links neither quest, so this PR doesn't conflict with feat(ts): translate f32 as f64 #296's edit to the adjacent lines. The new int quest links back to it under Related.

Follow-ups

  • None.

Review

Skipped: plan-only change (two quest files and two link lines), too trivial for a code review. quest check and just check passed locally on b105d36a.

🤖 Generated with Claude Code

(written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: b105d36

No actionable bugs found in these planning changes. The endian mappings match the current gaps, and preserving the input array is the right constraint. Separating integer conversions from exact fused multiply-add keeps the scope clear. For implementation, start with an exact reference path before optimizing f64, and include signed zero, cancellation, subnormal and overflow-boundary cases in the differential fixtures.

Verification: static review of the plans and current integer/float lowering only. No tests or builds run; the proposed FMA algorithms and native wasm32 behavior have not been experimentally verified.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 40 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cdab5ebc-2be1-43a2-86bc-de87aa8617eb
Commits

Reviewing files that changed from the base of the PR and between b105d36 and a238dac.

Files selected for processing: 3
  • quest/m3/README.md
  • quest/m3/ts-int-ne-bytes.md
  • quest/m3/ts-mul-add.md

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5a18ef11-7c9a-40c9-8838-b2e31f316a3d
Commits

Reviewing files that changed from the base of the PR and between cecbf0d and b105d36.

Files selected for processing: 3
  • quest/m3/README.md
  • quest/m3/ts-int-ne-bytes.md
  • quest/m3/ts-mul-add.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The changes add planning documents for integer byte-conversion methods and fused multiply-add translation. The required work list now includes these capabilities. The documents describe proposed implementation approaches and tests; they do not implement the translations.

Priority: Low

Merge Risk: Minimal · previous review b105d

This plan-only change is mergeable after normal checks; it does not implement or alter integer conversions or fused multiply-add behavior.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly summarizes the two planned changes: integer native-endian byte conversions and exact mul_add support.
Description check Passed The description directly explains the two quests, their scope, implementation approach, and no-impact plan-only change.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant