Repository navigation
chore(quest): plan integers' native-endian bytes and an exact mul_add - #300
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: b105d36
No actionable bugs found in these planning changes. The endian mappings match the current gaps, and preserving the input array is the right constraint. Separating integer conversions from exact fused multiply-add keeps the scope clear. For implementation, start with an exact reference path before optimizing f64, and include signed zero, cancellation, subnormal and overflow-boundary cases in the differential fixtures.
Verification: static review of the plans and current integer/float lowering only. No tests or builds run; the proposed FMA algorithms and native wasm32 behavior have not been experimentally verified.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 40 minutes. View limit details
No actionable comments were generated in the recent review.
|
Problem
#296 left two std gaps out of its scope. Both reproduce at
cecbf0d7with spans:unsupported call to core::num::<impl u32>::from_le_bytes,<impl u64>::to_ne_bytes, and<impl u64>::from_ne_bytes`f64::mul_add`, which rounds once, where JS would round twice(andf32::mul_addonce feat(ts): translate f32 as f64 #296 lands)Approach
Plans two m3 quests, each with its reproduction and implementation guidance:
[S]:from_le_bytesis in the same gap as the two_ne_methods, so the quest covers all three. Related to Unsafe code the translator can model, whosebytesgetters need them.[M]: round to odd plusMath.froundforf32; an error-free product and TwoSum with an exactBigIntfallback forf64.Both join m3 after "std accessors with no mapping", away from the
f32line #296 deletes, so the two PRs don't conflict.Impact
Alternatives
mul_add: the maintainer asked for one quest covering both.Choices made without asking
from_le_bytesjoins the_ne_quest because it's the same mapping gap in the same match arm.quest/m3/ts-unsafe.mdlinks neither quest, so this PR doesn't conflict with feat(ts): translate f32 as f64 #296's edit to the adjacent lines. The new int quest links back to it under Related.Follow-ups
Review
Skipped: plan-only change (two quest files and two link lines), too trivial for a code review.
quest checkandjust checkpassed locally onb105d36a.🤖 Generated with Claude Code
(written by Claude Opus 5.5)