Repository navigation
chore(quest): drop ts-bench-route, whose documented A/B run already works - #321
Conversation
Quest-Claim: cfced94c19429e31
…orks Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 8009c53
No actionable bugs found. Removing this obsolete quest is reasonable: ts/justfile already declares the long route argument and forwards it to the benchmark driver, matching the README's command. No runtime or API change is introduced, and avoiding an unnecessary argument-forwarding redesign keeps the change focused.
Verification limits: static inspection of the diff, recipe and documentation only. I did not run the benchmark, just parsing, or tests, and have not independently reproduced the reported end-to-end run.
(Written by OpenAI)
|
No actionable comments were generated in the recent review.
|
Closes quest/m3/ts-bench-route.md.
Problem
#314 reported that the A/B run in the TS README's bench section,
just ts bench --route main=<dir>, fails with "justfile does not contain recipe".Approach
The failure does not reproduce at HEAD. The recipe has declared
[arg("route", long)]since #37, so--route main=<dir>and--route=main=<dir>both bind the route, with or without a positional checkout, under the flake's just 1.58.0 (just --dry-run). The reported error only appears with a stray--(just ts bench -- --route main=<dir>), which ends just's flag parsing so thatmain=<dir>is read as a recipe name. The README doesn't use that form.The proof is the documented command, run once end to end:
just ts runforfixtures/codecandfixtures/taskintots/target/bench). This took 24 s.nix develop .#bench --command just ts bench --route main=<that>/ts/target/benchexited 0 in 580 s from a coldts/target, including the moq clone and release builds.maincolumn in Node, Bun, Chromium, and Firefox, and in the async handoff.main's bundles are the same bytes astranslated(44313 / 13496 gzip), as identical sources should give.This PR only deletes the quest and its link from
quest/m3/README.md. No code or docs change.Impact
Alternatives
*argstobench/main.ts, which would also expose--rounds,--seed, and--sample-ms. Dropped: the documented flag already works,main.tstakes a single--route, and nothing uses the other flags yet.Follow-ups
Checks
just cipassed on 625e965 in 1044 s (158 tests passed, 1 skipped).quest checkpassed on it;just ciwas not re-run.Review
gpt-6.1-sol, medium effort, viaquest review --base origin/main, round 1 on head 8009c53: no findings.Merge of main at
e5c40458into8009c531, as379f02ff, without conflicts. Recorded skip, too trivial to review;just checkpassed on379f02ff, and the PR touches only quest files.The orchestrator wrote this quest from a misread dry run; the agent's finding that
--routealready parses is right.🤖 Generated with Claude Code
(written by Claude Opus 5.5)