Skip to content

chore(quest): drop ts-bench-route, whose documented A/B run already works - #321

Merged
kixelated merged 4 commits into
mainfrom
quest/m3/ts-bench-route
Oct 31, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m3/ts-bench-route

Conversation

@kixelated

@kixelated kixelated commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Closes quest/m3/ts-bench-route.md.

Problem

#314 reported that the A/B run in the TS README's bench section, just ts bench --route main=<dir>, fails with "justfile does not contain recipe".

Approach

The failure does not reproduce at HEAD. The recipe has declared [arg("route", long)] since #37, so --route main=<dir> and --route=main=<dir> both bind the route, with or without a positional checkout, under the flake's just 1.58.0 (just --dry-run). The reported error only appears with a stray -- (just ts bench -- --route main=<dir>), which ends just's flag parsing so that main=<dir> is read as a recipe name. The README doesn't use that form.

The proof is the documented command, run once end to end:

  • Route: a second checkout of the merge-base d1a076e, with only its two translations built (just ts run for fixtures/codec and fixtures/task into ts/target/bench). This took 24 s.
  • nix develop .#bench --command just ts bench --route main=<that>/ts/target/bench exited 0 in 580 s from a cold ts/target, including the moq clone and release builds.
  • The report has a main column in Node, Bun, Chromium, and Firefox, and in the async handoff. main's bundles are the same bytes as translated (44313 / 13496 gzip), as identical sources should give.

This PR only deletes the quest and its link from quest/m3/README.md. No code or docs change.

Impact

  • Public API: none.

Alternatives

  • Forwarding trailing *args to bench/main.ts, which would also expose --rounds, --seed, and --sample-ms. Dropped: the documented flag already works, main.ts takes a single --route, and nothing uses the other flags yet.

Follow-ups

  • None.

Checks

Review

  • Codex gpt-6.1-sol, medium effort, via quest review --base origin/main, round 1 on head 8009c53: no findings.

Merge of main at e5c40458 into 8009c531, as 379f02ff, without conflicts. Recorded skip, too trivial to review; just check passed on 379f02ff, and the PR touches only quest files.

The orchestrator wrote this quest from a misread dry run; the agent's finding that --route already parses is right.

🤖 Generated with Claude Code

(written by Claude Opus 5.5)

@kixelated kixelated changed the title The TS benchmark's A/B route as documented chore(quest): drop ts-bench-route, whose documented A/B run already works Oct 31, 2026
@kixelated
kixelated marked this pull request as ready for review October 31, 2026 01:52

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 8009c53

No actionable bugs found. Removing this obsolete quest is reasonable: ts/justfile already declares the long route argument and forwards it to the benchmark driver, matching the README's command. No runtime or API change is introduced, and avoiding an unnecessary argument-forwarding redesign keeps the change focused.

Verification limits: static inspection of the diff, recipe and documentation only. I did not run the benchmark, just parsing, or tests, and have not independently reproduced the reported end-to-end run.

(Written by OpenAI)

@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 64ba0d3b-102c-48f9-9041-30b61411f82d
Commits

Reviewing files that changed from the base of the PR and between 49f119b and 8009c53.

Files selected for processing: 2
  • quest/m3/README.md
  • quest/m3/ts-bench-route.md
Files with no reviewable changes: 1
  • quest/m3/ts-bench-route.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The changes remove the document describing the TypeScript benchmark route mismatch and its proposed resolutions. They also remove a related deferred item from the README.

Merge Risk: Minimal · up to 8009c

This documentation-only cleanup presents no identified merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly identifies the main change: removing the ts-bench-route quest because the documented A/B run works.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description directly explains the deletion of the ts-bench-route quest and its README link. It also provides the reported issue, validation results, and impact.
Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated
kixelated merged commit 52a8900 into main Oct 31, 2026
@kixelated
kixelated deleted the quest/m3/ts-bench-route branch October 31, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant