remove redundant init functions, update godoc, and add some consts#8
Open
thaJeztah wants to merge 7 commits into
Open
remove redundant init functions, update godoc, and add some consts#8thaJeztah wants to merge 7 commits into
thaJeztah wants to merge 7 commits into
Conversation
1 task
thaJeztah
force-pushed
the
less_init_step1
branch
2 times, most recently
from
9537136 to
a19195c
Compare
Remove the init functions and instead set the variables directly. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
less_init_step1
branch
from
a19195c to
41af657
Compare
thaJeztah
changed the title
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This is mostly for documentation purposes; exporting the type allows the godoc to become visible. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The current implementation considers erase-modes for "lines" and "display" to be equivalent; while there's an overlap, they have distinct values. This patch: - Introduces type-aliases for each to make the lists self-describing. Aliases are used to remain backward-compatible. - Changes the EraseDisplay and EraseLine functions to use the corresponding type-alias. The EraseModes struct is left in place, although it's currently not used in the codebase itself; it's worth considering to mark it deprecated (and recommend users to use the defined consts). Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
less_init_step1
branch
from
41af657 to
3b86c2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove redundant init functions
Remove the init functions and instead set the variables directly.
touch-up godoc
export "esc" const
This is mostly for documentation purposes; exporting the type allows
the godoc to become visible.
define const for erase-modes
The current implementation considers erase-modes for "lines"
and "display" to be equivalent; while there's an overlap,
they have distinct values.
This patch:
Aliases are used to remain backward-compatible.
corresponding type-alias.
The EraseModes struct is left in place, although it's currently
not used in the codebase itself; it's worth considering to mark
it deprecated (and recommend users to use the defined consts).