Repository navigation
Replace secret-shaped test and doc values with documented examples - #27
Merged
Merged
Conversation
Contributor
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull Request Overview
The test fixture replacement is incomplete: the test still uses the redacted, secret-shaped AWS access-key placeholder, leaving an acceptance criterion unmet. This should be corrected before merging. Codacy reports the change is up to standards, with no quality findings or uncovered complex files identified.
About this PR
- Provide a clear PR rationale and verification summary for the fixture and documentation changes.
Test suggestions
- Validate AWS access-key detection using the replacement documented example rather than a redacted placeholder.
- Verify pseudonymization produces an AKIA-shaped value with 16 pseudonymous characters and does not produce a usable credential.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Validate AWS access-key detection using the replacement documented example rather than a redacted placeholder.
2. Verify pseudonymization produces an AKIA-shaped value with 16 pseudonymous characters and does not produce a usable credential.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
morpheuslord
force-pushed
the
fix/remove-leaked-test-key
branch
from
October 9, 2026 15:15
92f5788 to
3db0530
Compare
GitHub secret scanning flagged a temporary AWS access key ID in the privacy detector tests (tests/mcp/test_transforms.py), and Codacy flags the fake keys as hardcoded secrets too. None of them is a real credential: they are sample inputs for the redaction detectors. The fake credentials now live in tests/mcp/fake_secrets.py and are assembled from pieces at import time, so no complete key-shaped string (AWS key ids and secret, private key blocks, JWT, Slack token, SAS signature) appears in the source, while the detectors see the same values as before. The AWS samples are AWS's documented example keys. docs/MCP_PRIVACY.md printed a vault pseudonym of an access key ID that had the shape of a real key; it now describes the pseudonym's shape.
morpheuslord
force-pushed
the
fix/remove-leaked-test-key
branch
from
October 9, 2026 15:20
3db0530 to
3952725
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix