fix: emit ecrecover authorizer signer#966
Open
prd-carapulse[bot] wants to merge 5 commits into
Open
Conversation
Include the recovered signer in the EcrecoverAuthorizer SetIsAuthorized event so offchain consumers can reconstruct who signed delegated authorizations.
adhusson
reviewed
Jun 2, 2026
| address indexed authorized, | ||
| bool isAuthorized, | ||
| uint256 nonce, | ||
| address signer |
Contributor
There was a problem hiding this comment.
not sure where to put it, no clear consensus (github search), also don't think it matters much
adhusson
reviewed
Jun 2, 2026
Use the no-argument Foundry expectEmit helper in the signer event regression test.
This reverts commit 18194ab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signeraddress toEcrecoverAuthorizer.SetIsAuthorized.caller,authorizer,authorized) unchanged and appendssigneras event data.signer != authorizer.Request Context
C0B787HAFQX, thread_ts1780397877.321229ECRecoverAuthorizerdoesn’t allow to recover who was the signer, make a pr that fixes this"Test Plan
forge test --force --match-path test/SetIsAuthorizedWithSigTest.sol --match-test testEcrecoverAuthorizerEventEmitsSigner -vvvforge test --force --match-path test/SetIsAuthorizedWithSigTest.solforge build --force