Skip to content

[Certora] Reentrancy and View Reentrancy Specification#972

Merged
QGarchery merged 14 commits into
mainfrom
jochen/reentrancy
Jun 12, 2026
Merged

[Certora] Reentrancy and View Reentrancy Specification#972
QGarchery merged 14 commits into
mainfrom
jochen/reentrancy

Conversation

@jhoenicke

@jhoenicke jhoenicke commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

My take on the Reentrancy and View Reentrancy. This flags all occurrences where external functions are called after modifiying storage.

@jhoenicke jhoenicke self-assigned this Jun 3, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa6d36fee8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread certora/specs/Reentrancy.spec
Comment thread certora/specs/ReentrancyView.spec Outdated
Comment thread certora/specs/ReentrancyView.spec
chatgpt-codex-connector[bot]

This comment was marked as outdated.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e5ad4ccb8a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread certora/specs/Reentrancy.spec

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6634510aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread certora/specs/ReentrancyView.spec
Comment thread certora/confs/Reentrancy.conf Outdated
Comment thread certora/confs/Reentrancy.conf Outdated
Comment thread certora/confs/ReentrancyView.conf Outdated
Comment thread certora/confs/ReentrancyView.conf Outdated
Comment thread certora/specs/Reentrancy.spec
Comment thread certora/specs/Reentrancy.spec
Comment thread certora/specs/ReentrancyView.spec Outdated
Comment thread certora/specs/ReentrancyView.spec Outdated
Comment thread certora/specs/Reentrancy.spec Outdated
Comment thread certora/specs/ReentrancyView.spec Outdated
Comment thread certora/specs/ReentrancyView.spec Outdated
Comment thread certora/specs/ReentrancyView.spec Outdated
Comment thread certora/specs/ReentrancyView.spec Outdated
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com>
Co-authored-by: Jochen Hoenicke <hoenicke@gmail.com>
Signed-off-by: Jochen Hoenicke <hoenicke@gmail.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 117357ae1e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread certora/specs/ReentrancyView.spec Outdated
Comment thread certora/specs/ReentrancyView.spec Outdated
Signed-off-by: Jochen Hoenicke <hoenicke@gmail.com>
Comment thread certora/specs/Reentrancy.spec Outdated
Comment thread certora/specs/ReentrancyView.spec Outdated
Comment thread certora/specs/ReentrancyView.spec Outdated
QGarchery and others added 2 commits June 11, 2026 17:00
Co-authored-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
Signed-off-by: Quentin Garchery <garchery.quentin@gmail.com>
@QGarchery QGarchery force-pushed the jochen/reentrancy branch from ffcb60a to 240340d Compare June 11, 2026 16:26
@lilCertora

Copy link
Copy Markdown
Collaborator

LGTM

@QGarchery QGarchery merged commit caa99f3 into main Jun 12, 2026
52 checks passed
@QGarchery QGarchery deleted the jochen/reentrancy branch June 12, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants