fix: extend liquidation auction duration#978
Open
prd-carapulse[bot] wants to merge 1 commit into
Open
Conversation
MathisGD
reviewed
Jun 4, 2026
| uint256 constant MAX_SETTLEMENT_FEE_360_DAYS = 0.005e18; | ||
| uint32 constant MAX_CONTINUOUS_FEE = uint32(uint256(0.01e18) / uint256(365 days)); | ||
| uint256 constant TIME_TO_MAX_LIF = 15 minutes; | ||
| uint256 constant TIME_TO_MAX_LIF = 60 minutes; |
Contributor
There was a problem hiding this comment.
same
Suggested change
| uint256 constant TIME_TO_MAX_LIF = 60 minutes; | |
| uint256 constant TIME_TO_MAX_LIF = 1 hours; |
Contributor
There was a problem hiding this comment.
I feel like minutes is better here because it's more natural for this kind of duration (if i want to use 40 minutes for a test, there's less change) but no big deal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend
TIME_TO_MAX_LIFfrom 15 minutes to 60 minutes.