#10670: Add AGENTS.md for AI coding assistant guidance - #68
Conversation
Addresses mosip/mosip-config#10670 — adds a root AGENTS.md hub covering repo-wide overview, tech stack, build/test commands, configuration, and PR guidelines, plus per-module AGENTS.md guides for auditsweeper, certmanager, and databreachdetector, since this repo is a collection of three genuinely independent Python-based ops/security tools rather than a single application. Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughAdded repository-level and module-level ChangesAgent guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@AGENTS.md`:
- Around line 51-54: Clarify the Build & Test Commands section to distinguish
the absence of a shared product build from the root Maven project. Update the
root-build statement to note that the placeholder Maven project is retained
solely for CI, while preserving the documented root Maven command.
- Around line 84-94: Update the CI/testing guidance in AGENTS.md to describe
both sonar-check.yml and chart-lint-publish.yml as CI quality checks, removing
the claim that sonar-check.yml is the only gate. State the local Helm validation
command directly as helm lint helm/<module>, and remove the contradictory
statement that no local lint command is documented.
In `@databreachdetector/AGENTS.md`:
- Around line 38-42: Update the local report-file handling documented in
AGENTS.md and implemented by databreachdetector.py: restrict access to the
generated PII files, ensure they are not committed or shared, and delete each
file only after its MinIO upload is confirmed. If any files must be retained,
document the approved GDPR/MOSIP retention exception and its duration.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: e6033c2e-122c-4038-884a-4e641b9ab37b
📒 Files selected for processing (4)
AGENTS.mdauditsweeper/AGENTS.mdcertmanager/AGENTS.mddatabreachdetector/AGENTS.md
- Clarify that there is no shared product build, distinct from the placeholder root Maven project used only by the Sonar workflow. - Describe both CI quality checks (Sonar and Helm chart lint) and document the local helm lint command directly instead of saying none is documented. - Flag that databreachdetector's local PII report files are not deleted after upload and should be access-restricted and cleaned up manually. Addresses review comments on mosip#68 Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>
Addresses mosip/mosip-config#10670 — adds a root AGENTS.md hub plus per-module AGENTS.md guides (auditsweeper, certmanager, databreachdetector), since this repo is a collection of three independent Python-based ops/security tools rather than a single application.
Summary by CodeRabbit