Skip to content

#10670: Add AGENTS.md for AI coding assistant guidance - #68

Merged
Mahesh-Binayak merged 2 commits into
mosip:developfrom
chetankh239:agents-md-doc
Aug 12, 2026
Merged

#10670: Add AGENTS.md for AI coding assistant guidance#68
Mahesh-Binayak merged 2 commits into
mosip:developfrom
chetankh239:agents-md-doc

Conversation

@chetankh239

@chetankh239 chetankh239 commented Aug 10, 2026

Copy link
Copy Markdown

Addresses mosip/mosip-config#10670 — adds a root AGENTS.md hub plus per-module AGENTS.md guides (auditsweeper, certmanager, databreachdetector), since this repo is a collection of three independent Python-based ops/security tools rather than a single application.

Summary by CodeRabbit

  • Documentation
    • Added repository-wide development guidance covering project structure, technology, build and test workflows, configuration, credentials, and contribution practices.
    • Added module-specific guidance for auditing, certificate management, and data-breach detection tools.
    • Documented execution options, configuration requirements, deployment considerations, generated reports, and security constraints.
    • Clarified development rules, known limitations, fallback behavior, and safe handling of sensitive information.

Addresses mosip/mosip-config#10670 — adds a root
AGENTS.md hub covering repo-wide overview, tech stack, build/test commands,
configuration, and PR guidelines, plus per-module AGENTS.md guides for
auditsweeper, certmanager, and databreachdetector, since this repo is a
collection of three genuinely independent Python-based ops/security tools
rather than a single application.

Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ad73745f-7b0e-4777-a9ea-5bdab7e858a1

📥 Commits

Reviewing files that changed from the base of the PR and between 1532ce1 and 398079f.

📒 Files selected for processing (2)
  • AGENTS.md
  • databreachdetector/AGENTS.md

Walkthrough

Added repository-level and module-level AGENTS.md files. The documentation covers project structure, development workflows, execution paths, configuration fallbacks, known limitations, and credential-handling rules.

Changes

Agent guidance

Layer / File(s) Summary
Repository-wide development guidance
AGENTS.md
Documents module responsibilities, tooling, build and test commands, configuration flows, project layout, development workflows, known limitations, and secret-handling rules.
Module execution and operational guidance
auditsweeper/AGENTS.md, certmanager/AGENTS.md, databreachdetector/AGENTS.md
Documents module execution paths, configuration requirements, deployment behavior, generated reports, and credential safety rules.
Data breach detector constraints
databreachdetector/AGENTS.md
Documents scan configuration, tuning behavior, existing implementation constraints, and rules against unsupported regex or MinIO changes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Poem

Guidance blooms across the tree,
Clear commands mark the way to be.
Secrets stay masked,
Old limits stay tasked,
Agents work safely and free.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding AGENTS.md guidance files for AI coding assistants.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@AGENTS.md`:
- Around line 51-54: Clarify the Build & Test Commands section to distinguish
the absence of a shared product build from the root Maven project. Update the
root-build statement to note that the placeholder Maven project is retained
solely for CI, while preserving the documented root Maven command.
- Around line 84-94: Update the CI/testing guidance in AGENTS.md to describe
both sonar-check.yml and chart-lint-publish.yml as CI quality checks, removing
the claim that sonar-check.yml is the only gate. State the local Helm validation
command directly as helm lint helm/<module>, and remove the contradictory
statement that no local lint command is documented.

In `@databreachdetector/AGENTS.md`:
- Around line 38-42: Update the local report-file handling documented in
AGENTS.md and implemented by databreachdetector.py: restrict access to the
generated PII files, ensure they are not committed or shared, and delete each
file only after its MinIO upload is confirmed. If any files must be retained,
document the approved GDPR/MOSIP retention exception and its duration.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e6033c2e-122c-4038-884a-4e641b9ab37b

📥 Commits

Reviewing files that changed from the base of the PR and between b97b7b2 and 1532ce1.

📒 Files selected for processing (4)
  • AGENTS.md
  • auditsweeper/AGENTS.md
  • certmanager/AGENTS.md
  • databreachdetector/AGENTS.md

Comment thread AGENTS.md
Comment thread AGENTS.md Outdated
Comment thread databreachdetector/AGENTS.md Outdated
- Clarify that there is no shared product build, distinct from the
  placeholder root Maven project used only by the Sonar workflow.
- Describe both CI quality checks (Sonar and Helm chart lint) and
  document the local helm lint command directly instead of saying
  none is documented.
- Flag that databreachdetector's local PII report files are not
  deleted after upload and should be access-restricted and cleaned
  up manually.

Addresses review comments on mosip#68

Signed-off-by: Chetan Kumar Hirematha <chetankumar.h.239@gmail.com>
@Mahesh-Binayak
Mahesh-Binayak merged commit 0e8427c into mosip:develop Aug 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants