Repository navigation
Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
segunfamisa
approved these changes
Sep 29, 2026
segunfamisa
left a comment
segunfamisa
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this patch!
| import org.mozilla.fenix.helpers.perf.DetectMemoryLeaksRule | ||
| import org.mozilla.fenix.ui.robots.homeScreen | ||
| import org.mozilla.fenix.ui.robots.navigationToolbar | ||
| import androidx.compose.ui.test.junit4.v2.AndroidComposeTestRule as AndroidComposeTestRuleV2 |
Contributor
There was a problem hiding this comment.
Oh TIL - I didn't know there was already a V2 😁
Contributor
|
I'm not sure how the PR title gets resolved in the final commit message, but we may want to consider adding some specificity to the title - maybe something like "Bug 2073095 - Fix more tests that interact with top sites that are broken on nightly build variants" or "Bug 2073095 - Fix tests broken on nightly variant - top sites" or something like that :D |
pollym
changed the title
…ts on nightly. - SettingsAddonTests noCrashWithAddonInstalledTest(): this now just opens the first available top site tab, as this is not really the main point of the test. I've added a new method into HomeScreenRobot to support this. - HomeScreenTest: the bit where it is actually checking that default top sites are available uses the new method i added to say whether or not we expect them to be there (isDefaultPinnedShortcutsOnHomepage) - UnsubmittedCrashDialogTest: this was mocking the context but didn't actually use it, so i could just get rid of that part 🎉
pollym
force-pushed
the
fix-ui-tests-for-nightly
branch
from
October 1, 2026 09:13
5da29fa to
44de1aa
Compare
Contributor
Author
thanks for the review! have tweaked, and fixed the lint. (I wrote this whole patch using human fingers instead of ai, like a dinosaur, it probably shows in the language used. Nothing is load-bearing here at all 😂) |
Contributor
Author
lando-worker Bot
pushed a commit
that referenced
this pull request
Oct 1, 2026
…ts on nightly. r=sfamisa - SettingsAddonTests noCrashWithAddonInstalledTest(): this now just opens the first available top site tab, as this is not really the main point of the test. I've added a new method into HomeScreenRobot to support this. - HomeScreenTest: the bit where it is actually checking that default top sites are available uses the new method i added to say whether or not we expect them to be there (isDefaultPinnedShortcutsOnHomepage) - UnsubmittedCrashDialogTest: this was mocking the context but didn't actually use it, so i could just get rid of that part 🎉 [try is running here](https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=98489) Pull request: #372
|
Pull request closed by commit bcb6f6d |
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 5, 2026
…ts on nightly. r=sfamisa - SettingsAddonTests noCrashWithAddonInstalledTest(): this now just opens the first available top site tab, as this is not really the main point of the test. I've added a new method into HomeScreenRobot to support this. - HomeScreenTest: the bit where it is actually checking that default top sites are available uses the new method i added to say whether or not we expect them to be there (isDefaultPinnedShortcutsOnHomepage) - UnsubmittedCrashDialogTest: this was mocking the context but didn't actually use it, so i could just get rid of that part 🎉 [try is running here](https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=98489) Pull request: mozilla-firefox/firefox#372 UltraBlame original commit: 8416b77afecd92453829412467bd0323fe0988c7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 5, 2026
…ts on nightly. r=sfamisa - SettingsAddonTests noCrashWithAddonInstalledTest(): this now just opens the first available top site tab, as this is not really the main point of the test. I've added a new method into HomeScreenRobot to support this. - HomeScreenTest: the bit where it is actually checking that default top sites are available uses the new method i added to say whether or not we expect them to be there (isDefaultPinnedShortcutsOnHomepage) - UnsubmittedCrashDialogTest: this was mocking the context but didn't actually use it, so i could just get rid of that part 🎉 [try is running here](https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=98489) Pull request: mozilla-firefox/firefox#372 UltraBlame original commit: 8416b77afecd92453829412467bd0323fe0988c7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 5, 2026
…ts on nightly. r=sfamisa - SettingsAddonTests noCrashWithAddonInstalledTest(): this now just opens the first available top site tab, as this is not really the main point of the test. I've added a new method into HomeScreenRobot to support this. - HomeScreenTest: the bit where it is actually checking that default top sites are available uses the new method i added to say whether or not we expect them to be there (isDefaultPinnedShortcutsOnHomepage) - UnsubmittedCrashDialogTest: this was mocking the context but didn't actually use it, so i could just get rid of that part 🎉 [try is running here](https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=98489) Pull request: mozilla-firefox/firefox#372 UltraBlame original commit: 8416b77afecd92453829412467bd0323fe0988c7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SettingsAddonTests noCrashWithAddonInstalledTest(): this now just opens the first available top site tab, as this is not really the main point of the test. I've added a new method into HomeScreenRobot to support this.
HomeScreenTest: the bit where it is actually checking that default top sites are available uses the new method i added to say whether or not we expect them to be there (isDefaultPinnedShortcutsOnHomepage)
UnsubmittedCrashDialogTest: this was mocking the context but didn't actually use it, so i could just get rid of that part 🎉
try is running here
Lando: link
Bugzilla: bug 2073095
🚫 This pull request has 1 blocker.