Simplify heartbeat endpoint, don't call API, just return 200#14261
Open
diox wants to merge 2 commits into
Open
Simplify heartbeat endpoint, don't call API, just return 200#14261diox wants to merge 2 commits into
diox wants to merge 2 commits into
Conversation
Calling the API here would just cause us to needlessly spawn new pods if the API is erroring... but the frontend itself is fine.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14261 +/- ##
=======================================
Coverage 98.13% 98.14%
=======================================
Files 267 267
Lines 10664 10654 -10
Branches 3292 3287 -5
=======================================
- Hits 10465 10456 -9
+ Misses 186 185 -1
Partials 13 13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
eviljeff
approved these changes
Jun 25, 2026
| }; | ||
| }; | ||
|
|
||
| export const viewHeartbeatHandler = ({ |
Member
There was a problem hiding this comment.
In addons-server the heatlh checks are still available via another endpoint (monitors.json); in frontend this was it. So should this functionality be kept and made available via something similar to monitors.json?
Member
Author
There was a problem hiding this comment.
Good point, might be useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling the API here would just cause us to needlessly spawn new pods if the API is erroring... but the frontend itself is fine.
Second half of mozilla/addons#16297
See also mozilla/addons-server#25074