Skip to content

test(ads-client): added additional unit test for staging URL to ensure runtime safety.#7301

Merged
copyrighthero merged 2 commits intomozilla:mainfrom
copyrighthero:feat/ac-44--test-ads-client-staging-url
May 5, 2026
Merged

test(ads-client): added additional unit test for staging URL to ensure runtime safety.#7301
copyrighthero merged 2 commits intomozilla:mainfrom
copyrighthero:feat/ac-44--test-ads-client-staging-url

Conversation

@copyrighthero
Copy link
Copy Markdown
Contributor

@copyrighthero copyrighthero commented Apr 2, 2026

Changes

This PR added an additional unit test for the MARS staging URL to catch potential URL issues in the pipeline.

This PR also introduced a new shared component called url-macro that validates the URLs during compile time when devs choose to use the Url crate; investigation finds the repo have three main ways of coding URLs: const &str, Url::parse(), and Lazy<Url>, this utility could potentially help devs who prefer stricter verification before issues reach runtime.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
    • Note: This change adds a unit test.
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Note: This change adds a unit test, not CHANGELOG entry necessary.
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@copyrighthero copyrighthero force-pushed the feat/ac-44--test-ads-client-staging-url branch 2 times, most recently from afe863d to 3b84a84 Compare April 3, 2026 17:42
@copyrighthero copyrighthero requested review from Almaju and luc-lisi April 3, 2026 17:44
@copyrighthero copyrighthero force-pushed the feat/ac-44--test-ads-client-staging-url branch from 3b84a84 to c6f3b2e Compare April 30, 2026 21:36
@copyrighthero copyrighthero force-pushed the feat/ac-44--test-ads-client-staging-url branch from c6f3b2e to 705af8d Compare May 1, 2026 15:30
@copyrighthero copyrighthero added this pull request to the merge queue May 5, 2026
Merged via the queue into mozilla:main with commit 47829dc May 5, 2026
16 checks passed
@copyrighthero copyrighthero deleted the feat/ac-44--test-ads-client-staging-url branch May 5, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants