test(ads-client): added additional unit test for staging URL to ensure runtime safety.#7301
Merged
copyrighthero merged 2 commits intomozilla:mainfrom May 5, 2026
Conversation
afe863d to
3b84a84
Compare
3b84a84 to
c6f3b2e
Compare
c6f3b2e to
705af8d
Compare
Almaju
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR added an additional unit test for the MARS staging URL to catch potential URL issues in the pipeline.
This PR also introduced a new shared component called
url-macrothat validates the URLs during compile time when devs choose to use theUrlcrate; investigation finds the repo have three main ways of coding URLs: const &str, Url::parse(), andLazy<Url>, this utility could potentially help devs who prefer stricter verification before issues reach runtime.Pull Request checklist
[ci full]to the PR title.