Bug 2034534 - Use glean-sym to record a metric from places Rust implementation#7336
Bug 2034534 - Use glean-sym to record a metric from places Rust implementation#7336badboy wants to merge 1 commit intomozilla:mainfrom
Conversation
bendk
left a comment
bendk
left a comment
There was a problem hiding this comment.
This looks great to me and the plan of using Glean main for a bit is totally fine with me. The Rust changes look great, I'm excited to start using code like that myself.
| # file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
|
|
||
| --- | ||
| $schema: moz://mozilla.org/schemas/glean/metrics/2-0-0 |
There was a problem hiding this comment.
Should we merge this with components/places/android/metrics.yaml? I'm never sure where the best place for the metrics files to live, but with the new code it feels less tied to any particular mobile platform.
However, that would mean the build.rs code would process all the metrics. Maybe its better to wait until this experiment is successful to move forward with that. I'm feeling very 50/50 on this choice.
There was a problem hiding this comment.
yeah once we actually share the metrics we should use a single file. For now I figured it's best to keep it separate.
2 participants
This is not yet ready (I need to actually properly test it and also decide if those are the right metrics), but this is how I expect it to look.
Currently building against mozilla/glean#3426
The plan is to land that and a-s can depend on the git version (what is on
main) by then.